Update the filter_insights_api_response() utility function

in order to conform the output of the new Insights Advisor report
endpoint to our expections.
This commit is contained in:
Jeff Bradberry
2019-03-22 11:03:21 -04:00
parent f4b0910e98
commit 05f670a6d9

View File

@@ -2,42 +2,46 @@
# All Rights Reserved. # All Rights Reserved.
def filter_insights_api_response(json): # Old Insights API -> New API
new_json = {} #
''' # last_check_in -> checked_on
'last_check_in', # reports[] -> active_reports[]
'reports.[].rule.severity', # reports[].rule.{description,summary} -> active_reports[].rule.{description,summary}
'reports.[].rule.description', # reports[].rule.category -> active_reports[].rule.category.name
'reports.[].rule.category', # reports[].rule.severity (str) -> active_reports[].rule.total_risk (int)
'reports.[].rule.summary',
'reports.[].rule.ansible_fix',
'reports.[].rule.ansible',
'reports.[].maintenance_actions.[].maintenance_plan.name',
'reports.[].maintenance_actions.[].maintenance_plan.maintenance_id',
'''
if 'last_check_in' in json: # reports[].rule.{ansible,ansible_fix} appears to be unused
new_json['last_check_in'] = json['last_check_in'] # reports[].maintenance_actions[] missing entirely, will be provided
if 'reports' in json: # by a different Insights endpoint
def filter_insights_api_response(json):
severity_mapping = {
1: 'INFO',
2: 'WARN',
3: 'ERROR',
4: 'CRITICAL'
}
new_json = {}
if 'checked_on' in json:
new_json['last_check_in'] = json['checked_on']
if 'active_reports' in json:
new_json['reports'] = [] new_json['reports'] = []
for rep in json['reports']: for rep in json['active_reports']:
new_report = { new_report = {
'rule': {}, 'rule': {},
'maintenance_actions': [] 'maintenance_actions': [] # This will be populated by a different API call
} }
if 'rule' in rep: rule = rep.get('rule') or {}
for k in ['severity', 'description', 'category', 'summary', 'ansible_fix', 'ansible',]: for k in ['description', 'summary']:
if k in rep['rule']: if k in rule:
new_report['rule'][k] = rep['rule'][k] new_report['rule'][k] = rule[k]
if 'category' in rule:
new_report['category'] = rule['category']['name']
if rule.get('total_risk') in severity_mapping:
new_report['severity'] = severity_mapping[rule['total_risk']]
for action in rep.get('maintenance_actions', []):
new_action = {'maintenance_plan': {}}
if 'maintenance_plan' in action:
for k in ['name', 'maintenance_id']:
if k in action['maintenance_plan']:
new_action['maintenance_plan'][k] = action['maintenance_plan'][k]
new_report['maintenance_actions'].append(new_action)
new_json['reports'].append(new_report) new_json['reports'].append(new_report)
return new_json return new_json