Merge pull request #11184 from akus062381/user-date-detail-revised

change locator- UserDateDetail
This commit is contained in:
Sarah Akus
2021-10-01 15:07:24 -04:00
committed by GitHub
7 changed files with 4 additions and 26 deletions

View File

@@ -11,13 +11,13 @@ const Detail = styled(_Detail)`
word-break: break-word; word-break: break-word;
`; `;
function UserDateDetail({ label, date, user, dataCy = null }) { function UserDateDetail({ label, date, user }) {
const dateStr = formatDateString(date); const dateStr = formatDateString(date);
const username = user ? user.username : ''; const username = user ? user.username : '';
return ( return (
<Detail <Detail
label={label} label={label}
dataCy={dataCy} dataCy="user-date-detail"
value={ value={
user ? ( user ? (
<Trans> <Trans>

View File

@@ -238,14 +238,12 @@ function CredentialDetail({ credential }) {
{fields.map((field) => renderDetail(field))} {fields.map((field) => renderDetail(field))}
<UserDateDetail <UserDateDetail
dataCy="credential-created-detail"
id="credential-created-detail" id="credential-created-detail"
label={t`Created`} label={t`Created`}
date={created} date={created}
user={created_by} user={created_by}
/> />
<UserDateDetail <UserDateDetail
dataCy="credential-last_modified-detail"
id="credential-last_modified-detail" id="credential-last_modified-detail"
label={t`Last Modified`} label={t`Last Modified`}
date={modified} date={modified}

View File

@@ -99,13 +99,11 @@ function ExecutionEnvironmentDetails({ executionEnvironment }) {
label={t`Created`} label={t`Created`}
date={executionEnvironment.created} date={executionEnvironment.created}
user={executionEnvironment.summary_fields.created_by} user={executionEnvironment.summary_fields.created_by}
dataCy="execution-environment-created"
/> />
<UserDateDetail <UserDateDetail
label={t`Last Modified`} label={t`Last Modified`}
date={executionEnvironment.modified} date={executionEnvironment.modified}
user={executionEnvironment.summary_fields.modified_by} user={executionEnvironment.summary_fields.modified_by}
dataCy="execution-environment-modified"
/> />
</DetailList> </DetailList>
<CardActionsRow> <CardActionsRow>

View File

@@ -80,17 +80,11 @@ function HostDetail({ host }) {
</Link> </Link>
} }
/> />
<UserDateDetail <UserDateDetail date={created} label={t`Created`} user={created_by} />
date={created}
label={t`Created`}
user={created_by}
dataCy="host-created-by"
/>
<UserDateDetail <UserDateDetail
date={modified} date={modified}
label={t`Last Modified`} label={t`Last Modified`}
user={modified_by} user={modified_by}
dataCy="host-last-modified-by"
/> />
<VariablesDetail <VariablesDetail
label={t`Variables`} label={t`Variables`}

View File

@@ -404,16 +404,11 @@ function JobDetail({ job, inventorySourceLabels }) {
value={job.module_args} value={job.module_args}
/> />
<UserDateDetail <UserDateDetail
dataCy="job-created"
label={t`Created`} label={t`Created`}
date={job.created} date={job.created}
user={created_by} user={created_by}
/> />
<UserDateDetail <UserDateDetail label={t`Last Modified`} date={job.modified} />
dataCy="job-last-modified"
label={t`Last Modified`}
date={job.modified}
/>
{job.extra_vars && ( {job.extra_vars && (
<VariablesDetail <VariablesDetail
css="margin: 20px 0" css="margin: 20px 0"

View File

@@ -57,13 +57,11 @@ function UserTokenDetail({ token }) {
label={t`Created`} label={t`Created`}
date={created} date={created}
user={summary_fields.user} user={summary_fields.user}
dataCy="application-token-detail-created"
/> />
<UserDateDetail <UserDateDetail
label={t`Last Modified`} label={t`Last Modified`}
date={modified} date={modified}
user={summary_fields.user} user={summary_fields.user}
dataCy="application-token-detail-last-modified"
/> />
</DetailList> </DetailList>
<CardActionsRow> <CardActionsRow>

View File

@@ -150,27 +150,22 @@ function WorkflowApprovalDetail({ workflowApproval }) {
label={t`Created`} label={t`Created`}
date={workflowApproval.created} date={workflowApproval.created}
user={workflowApproval.summary_fields.created_by} user={workflowApproval.summary_fields.created_by}
dataCy="wa-detail-created-by"
/> />
<Detail <Detail
label={t`Last Modified`} label={t`Last Modified`}
value={formatDateString(workflowApproval.modified)} value={formatDateString(workflowApproval.modified)}
dataCy="wa-detail-last-modified"
/> />
<Detail <Detail
label={t`Finished`} label={t`Finished`}
value={formatDateString(workflowApproval.finished)} value={formatDateString(workflowApproval.finished)}
dataCy="wa-detail-finished"
/> />
<Detail <Detail
label={t`Canceled`} label={t`Canceled`}
value={formatDateString(workflowApproval.canceled_on)} value={formatDateString(workflowApproval.canceled_on)}
dataCy="wa-detail-canceled"
/> />
<Detail <Detail
label={t`Elapsed`} label={t`Elapsed`}
value={secondsToHHMMSS(workflowApproval.elapsed)} value={secondsToHHMMSS(workflowApproval.elapsed)}
dataCy="wa-detail-elapsed"
/> />
</DetailList> </DetailList>
<CardActionsRow> <CardActionsRow>