From 0cdcbdfea6435113714e31486cfe4ce3fd12f482 Mon Sep 17 00:00:00 2001 From: Ryan Petrello Date: Mon, 12 Oct 2020 12:56:13 -0400 Subject: [PATCH] fix a confusing error message when extra vars aren't valid JSON/YAML see: https://github.com/ansible/awx/issues/8359 --- awxkit/awxkit/cli/options.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/awxkit/awxkit/cli/options.py b/awxkit/awxkit/cli/options.py index 8b33a0d086..4d292f3611 100644 --- a/awxkit/awxkit/cli/options.py +++ b/awxkit/awxkit/cli/options.py @@ -178,6 +178,9 @@ class ResourceOptionsParser(object): except Exception: raise argparse.ArgumentTypeError("{} is not valid JSON or YAML".format(v)) + if not isinstance(parsed, dict): + raise argparse.ArgumentTypeError("{} is not valid JSON or YAML".format(v)) + for k, v in parsed.items(): # add support for file reading at top-level JSON keys # (to make things like SSH key data easier to work with)