External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-14 21:07:39 -02:30
Code Issues Packages Projects Releases Wiki Activity

JT validator: check for prompt_for cases to reject, and flake8

Browse Source
This commit is contained in:
AlanCoding
2016-04-09 16:31:32 -04:00
parent 52d8993aa8
commit 0dff851f62
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
awx/main/models/jobs.py
View File

@@ -251,6 +251,13 @@ class JobTemplate(UnifiedJobTemplate, JobOptions, ResourceMixin):
'force_handlers', 'skip_tags', 'start_at_task', 'become_enabled', 'force_handlers', 'skip_tags', 'start_at_task', 'become_enabled',
'labels',] 'labels',]
def clean(self):
if self.job_type == 'scan' and (self.inventory is None or self.ask_inventory_on_launch):
raise ValidationError('Scan jobs must be assigned a fixed inventory')
if (not self.ask_inventory_on_launch) and self.inventory is None:
raise ValidationError('Job Template must either have an inventory or allow prompting for inventory')
return super(JobTemplate, self).clean()
def create_job(self, **kwargs): def create_job(self, **kwargs):
''' '''
Create a new job based on this template. Create a new job based on this template.
@@ -265,9 +272,9 @@ class JobTemplate(UnifiedJobTemplate, JobOptions, ResourceMixin):
Return whether job template can be used to start a new job without Return whether job template can be used to start a new job without
requiring any user input. requiring any user input.
''' '''
return bool(self.credential and not len(self.passwords_needed_to_start) return bool(self.credential and not len(self.passwords_needed_to_start) and
and not len(self.variables_needed_to_start) not len(self.variables_needed_to_start) and
and self.inventory) self.inventory)
@property @property
def variables_needed_to_start(self): def variables_needed_to_start(self):