External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-02-18 11:40:05 -03:30
Code Issues Packages Projects Releases Wiki Activity

Only update selected instance groups if the select button is clicked in the modal

Browse Source
This commit is contained in:
mabashian
2019-01-30 15:27:02 -05:00
parent 6ed36daef7
commit 0e9e17f957
4 changed files with 141 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

85
__tests__/components/Lookup.test.jsx
View File

@@ -3,34 +3,41 @@ import { mount } from 'enzyme';
import { I18nProvider } from '@lingui/react';
import Lookup from '../../src/components/Lookup';
let mockData = [{ name: 'foo', id: 0, isChecked: false }];
let mockData = [{ name: 'foo', id: 1, isChecked: false }];
describe('<Lookup />', () => {
test('initially renders succesfully', () => {
mount(
<Lookup
lookup_header="Foo Bar"
lookupChange={() => { }}
onLookupSave={() => { }}
data={mockData}
selected={[]}
/>
);
});
test('calls "onLookup" when search icon is clicked', () => {
const spy = jest.spyOn(Lookup.prototype, 'onLookup');
test('Opens modal when search icon is clicked', () => {
const spy = jest.spyOn(Lookup.prototype, 'handleModalToggle');
const mockSelected = [{ name: 'foo', id: 1 }];
const wrapper = mount(
<I18nProvider>
<Lookup
lookup_header="Foo Bar"
lookupChange={() => { }}
onLookupSave={() => { }}
data={mockData}
selected={[]}
selected={mockSelected}
/>
</I18nProvider>
);
).find('Lookup');
expect(spy).not.toHaveBeenCalled();
expect(wrapper.state('lookupSelectedItems')).toEqual([]);
const searchItem = wrapper.find('.pf-c-input-group__text#search');
searchItem.first().simulate('click');
expect(spy).toHaveBeenCalled();
expect(wrapper.state('lookupSelectedItems')).toEqual([{
id: 1,
name: 'foo'
}]);
expect(wrapper.state('isModalOpen')).toEqual(true);
});
test('calls "toggleSelected" when a user changes a checkbox', () => {
const spy = jest.spyOn(Lookup.prototype, 'toggleSelected');
@@ -38,7 +45,7 @@ describe('<Lookup />', () => {
<I18nProvider>
<Lookup
lookup_header="Foo Bar"
lookupChange={() => { }}
onLookupSave={() => { }}
data={mockData}
selected={[]}
/>
@@ -51,14 +58,15 @@ describe('<Lookup />', () => {
});
test('calls "toggleSelected" when remove icon is clicked', () => {
const spy = jest.spyOn(Lookup.prototype, 'toggleSelected');
mockData = [{ name: 'foo', id: 0, isChecked: false }, { name: 'bar', id: 1, isChecked: true }];
mockData = [{ name: 'foo', id: 1, isChecked: false }, { name: 'bar', id: 2, isChecked: true }];
const mockSelected = [{ name: 'foo', id: 1 }, { name: 'bar', id: 2 }];
const wrapper = mount(
<I18nProvider>
<Lookup
lookup_header="Foo Bar"
lookupChange={() => { }}
onLookupSave={() => { }}
data={mockData}
selected={[]}
selected={mockSelected}
/>
</I18nProvider>
);
@@ -73,7 +81,7 @@ describe('<Lookup />', () => {
<I18nProvider>
<Lookup
lookup_header="Foo Bar"
lookupChange={() => { }}
onLookupSave={() => { }}
data={mockData}
selected={[]}
/>
@@ -83,4 +91,57 @@ describe('<Lookup />', () => {
const pill = wrapper.find('span.awx-c-tag--pill');
expect(pill).toHaveLength(0);
});
test('toggleSelected successfully adds/removes row from lookupSelectedItems state', () => {
mockData = [{ name: 'foo', id: 1 }];
const wrapper = mount(
<I18nProvider>
<Lookup
lookup_header="Foo Bar"
onLookupSave={() => { }}
data={mockData}
selected={[]}
/>
</I18nProvider>
).find('Lookup');
wrapper.instance().toggleSelected({
id: 1,
name: 'foo'
});
expect(wrapper.state('lookupSelectedItems')).toEqual([{
id: 1,
name: 'foo'
}]);
wrapper.instance().toggleSelected({
id: 1,
name: 'foo'
});
expect(wrapper.state('lookupSelectedItems')).toEqual([]);
});
test('saveModal calls callback with selected items', () => {
mockData = [{ name: 'foo', id: 1 }];
const onLookupSaveFn = jest.fn();
const wrapper = mount(
<I18nProvider>
<Lookup
lookup_header="Foo Bar"
onLookupSave={onLookupSaveFn}
data={mockData}
selected={[]}
/>
</I18nProvider>
).find('Lookup');
wrapper.instance().toggleSelected({
id: 1,
name: 'foo'
});
expect(wrapper.state('lookupSelectedItems')).toEqual([{
id: 1,
name: 'foo'
}]);
wrapper.instance().saveModal();
expect(onLookupSaveFn).toHaveBeenCalledWith([{
id: 1,
name: 'foo'
}]);
});
});

55
__tests__/pages/Organizations/screens/OrganizationAdd.test.jsx
View File

@@ -93,6 +93,26 @@ describe('<OrganizationAdd />', () => {
});
});
test('updateSelectedInstanceGroups successfully sets selectedInstanceGroups state', () => {
const wrapper = mount(
<MemoryRouter>
<OrganizationAdd api={{}} />
</MemoryRouter>
).find('OrganizationAdd');
wrapper.instance().updateSelectedInstanceGroups([
{
id: 1,
name: 'foo'
}
]);
expect(wrapper.state('selectedInstanceGroups')).toEqual([
{
id: 1,
name: 'foo'
}
]);
});
test('onSelectChange successfully sets custom_virtualenv state', () => {
const wrapper = mount(
<MemoryRouter>
@@ -103,41 +123,6 @@ describe('<OrganizationAdd />', () => {
expect(wrapper.state('custom_virtualenv')).toBe('foobar');
});
test('onLookupChange successfully adds/removes row from selectedInstanceGroups state', () => {
const wrapper = mount(
<MemoryRouter>
<OrganizationAdd api={{}} />
</MemoryRouter>
).find('OrganizationAdd');
wrapper.setState({ results: [{
id: 1,
name: 'foo'
}] });
wrapper.instance().onLookupChange({
id: 1,
name: 'foo'
});
expect(wrapper.state('results')).toEqual([{
id: 1,
name: 'foo',
isChecked: true
}]);
expect(wrapper.state('selectedInstanceGroups')).toEqual([{
id: 1,
name: 'foo'
}]);
wrapper.instance().onLookupChange({
id: 1,
name: 'foo'
});
expect(wrapper.state('results')).toEqual([{
id: 1,
name: 'foo',
isChecked: false
}]);
expect(wrapper.state('selectedInstanceGroups')).toEqual([]);
});
test('onSubmit posts instance groups from selectedInstanceGroups', async () => {
const createOrganizationFn = jest.fn().mockResolvedValue({
data: {