From 0f24ed954c984a41d0becd9f2d28cf2c2df008a7 Mon Sep 17 00:00:00 2001 From: John Mitchell Date: Tue, 27 Jan 2015 16:14:18 -0500 Subject: [PATCH] using join instead of the for loop --- awx/ui/static/js/helpers/EventViewer.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/awx/ui/static/js/helpers/EventViewer.js b/awx/ui/static/js/helpers/EventViewer.js index 409f0e0266..898c464429 100644 --- a/awx/ui/static/js/helpers/EventViewer.js +++ b/awx/ui/static/js/helpers/EventViewer.js @@ -461,7 +461,7 @@ angular.module('EventViewerHelper', ['ModalDialog', 'Utilities', 'EventsViewerFo } function parseJSON(obj) { - var h, html = '', key, keys, found = false, i = 0, string_warnings = "", string_cmd = ""; + var h, html = '', key, keys, found = false, string_warnings = "", string_cmd = ""; if (typeof obj === "object") { html += "\n"; html += "\n"; @@ -498,9 +498,7 @@ angular.module('EventViewerHelper', ['ModalDialog', 'Utilities', 'EventsViewerFo // only show cmd if it's a cmd that was run if (!EventsViewerForm.fields[key] && obj[key].length > 0) { // include the label head Shell Command instead of CMD in the modal - for (i = 0; i < obj[key].length; i++) { - string_cmd += obj[key][i] + " "; - } + string_cmd += obj[key].join(" "); h = parseItem(string_cmd, key, "Shell Command"); if (h) { html += h; @@ -509,9 +507,7 @@ angular.module('EventViewerHelper', ['ModalDialog', 'Utilities', 'EventsViewerFo } } else if (key === 'warnings') { if (!EventsViewerForm.fields[key] && obj[key].length > 0) { - for (i = 0; i < obj[key].length; i++) { - string_warnings += obj[key][i] + " "; - } + string_warnings += obj[key].join(" "); h = parseItem(string_warnings, key, "Warnings"); if (h) { html += h;