From d6b56d8794d3e877eb151721e911560e00512370 Mon Sep 17 00:00:00 2001 From: nixocio Date: Mon, 11 May 2020 13:28:33 -0400 Subject: [PATCH] Update strings to follow `sentence capitalization` style Also, add note about `sentence capitalization` in the ui_next docs. See: https://www.patternfly.org/v4/design-guidelines/content/grammar-and-terminology#capitalization --- awx/ui_next/CONTRIBUTING.md | 1 + awx/ui_next/src/components/CodeMirrorInput/VariablesField.jsx | 2 +- awx/ui_next/src/components/FieldWithPrompt/FieldWithPrompt.jsx | 2 +- .../screens/Template/JobTemplateDetail/JobTemplateDetail.jsx | 2 +- .../WorkflowJobTemplateDetail/WorkflowJobTemplateDetail.jsx | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/awx/ui_next/CONTRIBUTING.md b/awx/ui_next/CONTRIBUTING.md index e9def0cefb..e7bafdc445 100644 --- a/awx/ui_next/CONTRIBUTING.md +++ b/awx/ui_next/CONTRIBUTING.md @@ -35,6 +35,7 @@ Have questions about this document or anything not covered here? Feel free to re - functions should adopt camelCase - constructors/classes should adopt PascalCase - constants to be exported should adopt UPPERCASE +- For strings, we adopt the `sentence capitalization` since it is a (patternfly style guide)[https://www.patternfly.org/v4/design-guidelines/content/grammar-and-terminology#capitalization]. ## Setting up your development environment diff --git a/awx/ui_next/src/components/CodeMirrorInput/VariablesField.jsx b/awx/ui_next/src/components/CodeMirrorInput/VariablesField.jsx index c8049328a8..54bd70bc2c 100644 --- a/awx/ui_next/src/components/CodeMirrorInput/VariablesField.jsx +++ b/awx/ui_next/src/components/CodeMirrorInput/VariablesField.jsx @@ -64,7 +64,7 @@ function VariablesField({ {promptId && ( )} diff --git a/awx/ui_next/src/components/FieldWithPrompt/FieldWithPrompt.jsx b/awx/ui_next/src/components/FieldWithPrompt/FieldWithPrompt.jsx index 8932c7cbe4..9050307c83 100644 --- a/awx/ui_next/src/components/FieldWithPrompt/FieldWithPrompt.jsx +++ b/awx/ui_next/src/components/FieldWithPrompt/FieldWithPrompt.jsx @@ -45,7 +45,7 @@ function FieldWithPrompt({ diff --git a/awx/ui_next/src/screens/Template/JobTemplateDetail/JobTemplateDetail.jsx b/awx/ui_next/src/screens/Template/JobTemplateDetail/JobTemplateDetail.jsx index 28bdcec16f..6412dc447d 100644 --- a/awx/ui_next/src/screens/Template/JobTemplateDetail/JobTemplateDetail.jsx +++ b/awx/ui_next/src/screens/Template/JobTemplateDetail/JobTemplateDetail.jsx @@ -143,7 +143,7 @@ function JobTemplateDetail({ i18n, template }) { {summary_fields.inventory.name} - {i18n._(t`(Prompt on Launch)`)} + {i18n._(t`(Prompt on launch)`)} ) : ( diff --git a/awx/ui_next/src/screens/Template/WorkflowJobTemplateDetail/WorkflowJobTemplateDetail.jsx b/awx/ui_next/src/screens/Template/WorkflowJobTemplateDetail/WorkflowJobTemplateDetail.jsx index 93aa40a212..f6420cf577 100644 --- a/awx/ui_next/src/screens/Template/WorkflowJobTemplateDetail/WorkflowJobTemplateDetail.jsx +++ b/awx/ui_next/src/screens/Template/WorkflowJobTemplateDetail/WorkflowJobTemplateDetail.jsx @@ -88,7 +88,7 @@ function WorkflowJobTemplateDetail({ template, i18n }) { - {i18n._(t`(Prompt on Launch)`)} + {i18n._(t`(Prompt on launch)`)} ) : (