External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-02-28 00:08:44 -03:30
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1817 from AlanCoding/notification_fail

Browse Source 
Do not fail entire notification chain if one fails
This commit is contained in:
Alan Rominger
2018-05-17 10:06:03 -04:00
committed by GitHub
parent 5bbbb87fee f9871f32a3
commit 14d10a93cc
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
awx/main/tasks.py
View File

@@ -255,7 +255,10 @@ def send_notifications(notification_list, job_id=None):
notification.error = smart_str(e) notification.error = smart_str(e)
update_fields.append('error') update_fields.append('error')
finally: finally:
notification.save(update_fields=update_fields) try:
notification.save(update_fields=update_fields)
except Exception as e:
logger.exception(six.text_type('Error saving notification {} result.').format(notification.id))
@shared_task(bind=True, queue=settings.CELERY_DEFAULT_QUEUE) @shared_task(bind=True, queue=settings.CELERY_DEFAULT_QUEUE)