diff --git a/awx/ui_next/src/components/Schedule/Schedule.jsx b/awx/ui_next/src/components/Schedule/Schedule.jsx index 852f811b40..7efd41e4ea 100644 --- a/awx/ui_next/src/components/Schedule/Schedule.jsx +++ b/awx/ui_next/src/components/Schedule/Schedule.jsx @@ -111,26 +111,17 @@ function Schedule({ i18n, setBreadcrumb, unifiedJobTemplate }) { { - return ; - }} - />, + > + + , ]} - { - return ( - - {unifiedJobTemplate && ( - - {i18n._(t`View Details`)} - - )} - - ); - }} - /> + + + {unifiedJobTemplate && ( + {i18n._(t`View Details`)} + )} + + ); diff --git a/awx/ui_next/src/components/Schedule/Schedules.jsx b/awx/ui_next/src/components/Schedule/Schedules.jsx index 297c9c475a..a615fa89a9 100644 --- a/awx/ui_next/src/components/Schedule/Schedules.jsx +++ b/awx/ui_next/src/components/Schedule/Schedules.jsx @@ -14,32 +14,21 @@ function Schedules({ return ( - } - /> - ( - - )} - /> - { - return ( - - ); - }} - /> + + + + + + + + + ); } diff --git a/awx/ui_next/src/screens/Credential/Credential.jsx b/awx/ui_next/src/screens/Credential/Credential.jsx index e41eae2561..3e1d831ced 100644 --- a/awx/ui_next/src/screens/Credential/Credential.jsx +++ b/awx/ui_next/src/screens/Credential/Credential.jsx @@ -98,59 +98,43 @@ function Credential({ i18n, setBreadcrumb }) { exact /> {credential && [ - } - />, - } - />, + + + , + + + , credential.organization && ( - ( - - )} - /> + + + ), - - !hasContentLoading && ( - - {match.params.id && ( - - {i18n._(`View Credential Details`)} - - )} - - ) - } - />, - ]} - - !hasContentLoading && ( + + {!hasContentLoading && ( - {id && ( - + {match.params.id && ( + {i18n._(`View Credential Details`)} )} - ) - } - /> + )} + , + ]} + + {!hasContentLoading && ( + + {id && ( + + {i18n._(`View Credential Details`)} + + )} + + )} + diff --git a/awx/ui_next/src/screens/Host/HostGroups/HostGroups.jsx b/awx/ui_next/src/screens/Host/HostGroups/HostGroups.jsx index ec4fe08ceb..235d233493 100644 --- a/awx/ui_next/src/screens/Host/HostGroups/HostGroups.jsx +++ b/awx/ui_next/src/screens/Host/HostGroups/HostGroups.jsx @@ -1,20 +1,14 @@ import React from 'react'; import { withI18n } from '@lingui/react'; - import { Switch, Route } from 'react-router-dom'; - import HostGroupsList from './HostGroupsList'; function HostGroups({ host }) { return ( - { - return ; - }} - /> + + + ); } diff --git a/awx/ui_next/src/screens/Inventory/Inventories.jsx b/awx/ui_next/src/screens/Inventory/Inventories.jsx index 71ace802cc..e93269cf93 100644 --- a/awx/ui_next/src/screens/Inventory/Inventories.jsx +++ b/awx/ui_next/src/screens/Inventory/Inventories.jsx @@ -85,14 +85,12 @@ class Inventories extends Component { <> - } - /> - } - /> + + + + + + {({ me }) => ( @@ -119,7 +117,9 @@ class Inventories extends Component { )} /> - } /> + + + ); diff --git a/awx/ui_next/src/screens/Inventory/InventoryGroup/InventoryGroup.jsx b/awx/ui_next/src/screens/Inventory/InventoryGroup/InventoryGroup.jsx index ab913d3592..c05e53a675 100644 --- a/awx/ui_next/src/screens/Inventory/InventoryGroup/InventoryGroup.jsx +++ b/awx/ui_next/src/screens/Inventory/InventoryGroup/InventoryGroup.jsx @@ -137,21 +137,15 @@ function InventoryGroup({ i18n, setBreadcrumb, inventory }) { , ]} - { - return ( - - {inventory && ( - - {i18n._(t`View Inventory Details`)} - - )} - - ); - }} - /> + + + {inventory && ( + + {i18n._(t`View Inventory Details`)} + + )} + + ); diff --git a/awx/ui_next/src/screens/Inventory/InventoryGroups/InventoryGroups.jsx b/awx/ui_next/src/screens/Inventory/InventoryGroups/InventoryGroups.jsx index 5b8ecdbbbb..6299578904 100644 --- a/awx/ui_next/src/screens/Inventory/InventoryGroups/InventoryGroups.jsx +++ b/awx/ui_next/src/screens/Inventory/InventoryGroups/InventoryGroups.jsx @@ -11,32 +11,18 @@ import InventoryGroupsList from './InventoryGroupsList'; function InventoryGroups({ setBreadcrumb, inventory }) { return ( - { - return ( - - ); - }} - /> - ( - - )} - /> - { - return ; - }} - /> + + + + + + + + + ); } diff --git a/awx/ui_next/src/screens/Inventory/InventoryHostGroups/InventoryHostGroups.jsx b/awx/ui_next/src/screens/Inventory/InventoryHostGroups/InventoryHostGroups.jsx index ef90103734..55ffbe05cb 100644 --- a/awx/ui_next/src/screens/Inventory/InventoryHostGroups/InventoryHostGroups.jsx +++ b/awx/ui_next/src/screens/Inventory/InventoryHostGroups/InventoryHostGroups.jsx @@ -8,13 +8,9 @@ import InventoryHostGroupsList from './InventoryHostGroupsList'; function InventoryHostGroups() { return ( - { - return ; - }} - /> + + + ); } diff --git a/awx/ui_next/src/screens/Inventory/SmartInventory.jsx b/awx/ui_next/src/screens/Inventory/SmartInventory.jsx index 2a6a1c8ca3..e37cd1c4d6 100644 --- a/awx/ui_next/src/screens/Inventory/SmartInventory.jsx +++ b/awx/ui_next/src/screens/Inventory/SmartInventory.jsx @@ -119,33 +119,27 @@ class SmartInventory extends Component { ( - - )} - />, - } - />, + > + + , + + + , ( - - )} - />, - } - />, + > + + , + + + , , - - !hasContentLoading && ( - - {match.params.id && ( - - {i18n._(`View Inventory Details`)} - - )} - - ) - } - />, + + {!hasContentLoading && ( + + {match.params.id && ( + + {i18n._(`View Inventory Details`)} + + )} + + )} + , ]} diff --git a/awx/ui_next/src/screens/Job/Job.jsx b/awx/ui_next/src/screens/Job/Job.jsx index 7f0da98d40..e945b284c8 100644 --- a/awx/ui_next/src/screens/Job/Job.jsx +++ b/awx/ui_next/src/screens/Job/Job.jsx @@ -124,53 +124,34 @@ class Job extends Component { to="/jobs/:type/:id/output" exact /> - - job && - job.type === 'workflow_job' && - } - /> - - job && - job.type === 'workflow_job' && - } - /> + {job && + job.type === 'workflow_job' && [ + + + , + + + , + ]} {job && job.type !== 'workflow_job' && [ - ( - + + + , + + + , + + {!hasContentLoading && ( + + + {i18n._(`View Job Details`)} + + )} - />, - ( - - )} - />, - - !hasContentLoading && ( - - - {i18n._(`View Job Details`)} - - - ) - } - />, + , ]} diff --git a/awx/ui_next/src/screens/Job/Jobs.jsx b/awx/ui_next/src/screens/Job/Jobs.jsx index b5008c3423..e1d5e4e528 100644 --- a/awx/ui_next/src/screens/Job/Jobs.jsx +++ b/awx/ui_next/src/screens/Job/Jobs.jsx @@ -4,6 +4,7 @@ import { Switch, useHistory, useLocation, + useParams, useRouteMatch, } from 'react-router-dom'; import { withI18n } from '@lingui/react'; @@ -18,6 +19,7 @@ import { JOB_TYPE_URL_SEGMENTS } from '@constants'; function Jobs({ i18n }) { const history = useHistory(); const location = useLocation(); + const { id } = useParams(); const match = useRouteMatch(); const [breadcrumbConfig, setBreadcrumbConfig] = useState({ '/jobs': i18n._(t`Jobs`), @@ -52,34 +54,22 @@ function Jobs({ i18n }) { /> - ( - - )} - /> - ( - - )} - /> - ( - - )} - /> - ( - - )} - /> + + + + + + + + + + + + ); diff --git a/awx/ui_next/src/screens/Organization/Organization.jsx b/awx/ui_next/src/screens/Organization/Organization.jsx index ac366fa71f..f2bcd6f91e 100644 --- a/awx/ui_next/src/screens/Organization/Organization.jsx +++ b/awx/ui_next/src/screens/Organization/Organization.jsx @@ -176,61 +176,46 @@ class Organization extends Component { exact /> {organization && ( - } - /> + + + )} {organization && ( - ( - - )} - /> + + + )} {organization && ( - ( - - )} - /> + + + )} - } - /> + + + {canSeeNotificationsTab && ( - ( - - )} - /> + + + )} - - !hasContentLoading && ( - - {match.params.id && ( - - {i18n._(`View Organization Details`)} - - )} - - ) - } - /> + + {!hasContentLoading && ( + + {match.params.id && ( + + {i18n._(`View Organization Details`)} + + )} + + )} + , diff --git a/awx/ui_next/src/screens/Organization/Organizations.jsx b/awx/ui_next/src/screens/Organization/Organizations.jsx index 58dc8c2e2f..1cc09a68ba 100644 --- a/awx/ui_next/src/screens/Organization/Organizations.jsx +++ b/awx/ui_next/src/screens/Organization/Organizations.jsx @@ -55,26 +55,24 @@ class Organizations extends Component { - } - /> - ( - - {({ me }) => ( - - )} - - )} - /> - } /> + + + + + + {({ me }) => ( + + )} + + + + + ); diff --git a/awx/ui_next/src/screens/Project/Project.jsx b/awx/ui_next/src/screens/Project/Project.jsx index 1161e3f378..debd3aaae6 100644 --- a/awx/ui_next/src/screens/Project/Project.jsx +++ b/awx/ui_next/src/screens/Project/Project.jsx @@ -192,75 +192,54 @@ class Project extends Component { {project && ( - } - /> + + + )} {project && ( - } - /> + + + )} {project && ( - ( - - )} - /> + + + )} {canSeeNotificationsTab && ( - ( - - )} - /> + + + )} - ( - - )} - /> + + + {project?.scm_type && project.scm_type !== '' && ( - ( - - )} - /> + + + )} - - !hasContentLoading && ( - - {match.params.id && ( - - {i18n._(`View Project Details`)} - - )} - - ) - } - /> + + {!hasContentLoading && ( + + {match.params.id && ( + + {i18n._(`View Project Details`)} + + )} + + )} + , diff --git a/awx/ui_next/src/screens/Project/Projects.jsx b/awx/ui_next/src/screens/Project/Projects.jsx index 0c25bfb0a2..6dba9ce98e 100644 --- a/awx/ui_next/src/screens/Project/Projects.jsx +++ b/awx/ui_next/src/screens/Project/Projects.jsx @@ -62,23 +62,24 @@ class Projects extends Component { - } /> - ( - - {({ me }) => ( - - )} - - )} - /> - } /> + + + + + + {({ me }) => ( + + )} + + + + + ); diff --git a/awx/ui_next/src/screens/Team/Team.jsx b/awx/ui_next/src/screens/Team/Team.jsx index 705ed88105..a702970c39 100644 --- a/awx/ui_next/src/screens/Team/Team.jsx +++ b/awx/ui_next/src/screens/Team/Team.jsx @@ -87,38 +87,31 @@ function Team({ i18n, setBreadcrumb }) { )} {team && ( - } - /> + + + )} {team && ( - Coming soon :)} - /> + + Coming soon :) + )} {team && ( - Coming soon :)} - /> + + Coming soon :) + )} - - !hasContentLoading && ( - - {id && ( - - {i18n._(`View Team Details`)} - - )} - - ) - } - /> + + {!hasContentLoading && ( + + {id && ( + + {i18n._(`View Team Details`)} + + )} + + )} + diff --git a/awx/ui_next/src/screens/Template/Templates.jsx b/awx/ui_next/src/screens/Template/Templates.jsx index 40fdca7604..3ade3ef294 100644 --- a/awx/ui_next/src/screens/Template/Templates.jsx +++ b/awx/ui_next/src/screens/Template/Templates.jsx @@ -80,14 +80,12 @@ class Templates extends Component { <> - } - /> - } - /> + + + + + + ( @@ -119,7 +117,9 @@ class Templates extends Component { )} /> - } /> + + + ); diff --git a/awx/ui_next/src/screens/Template/WorkflowJobTemplate.jsx b/awx/ui_next/src/screens/Template/WorkflowJobTemplate.jsx index 9438fda421..f07f51db12 100644 --- a/awx/ui_next/src/screens/Template/WorkflowJobTemplate.jsx +++ b/awx/ui_next/src/screens/Template/WorkflowJobTemplate.jsx @@ -210,61 +210,52 @@ class WorkflowJobTemplate extends Component { ( - - )} - /> + > + + )} {template && ( - ( - - )} - /> + + + )} {canSeeNotificationsTab && ( - ( - - )} - /> + + + )} {template && ( ( - - )} - /> + > + + )} {template && ( ( - - - - - - )} - /> + > + + + + + + )} {template?.id && ( @@ -276,39 +267,32 @@ class WorkflowJobTemplate extends Component { )} {template?.id && ( - ( - - )} - /> + + + )} {template && ( )} - ( - - {match.params.id && ( - - {i18n._(`View Template Details`)} - - )} - - )} - /> + + + {match.params.id && ( + + {i18n._(`View Template Details`)} + + )} + + diff --git a/awx/ui_next/src/screens/User/User.jsx b/awx/ui_next/src/screens/User/User.jsx index d2398846f9..c63cb569a8 100644 --- a/awx/ui_next/src/screens/User/User.jsx +++ b/awx/ui_next/src/screens/User/User.jsx @@ -119,54 +119,43 @@ class User extends Component { {user && ( - } - /> + + + )} {user && ( - } - /> + + + )} - } - /> + + + {user && ( - ( - - this needs a different access list from regular resources - like proj, inv, jt - - )} - /> + + + this needs a different access list from regular resources like + proj, inv, jt + + )} - } - /> - - !hasContentLoading && ( - - {match.params.id && ( - - {i18n._(`View User Details`)} - - )} - - ) - } - /> + + + + + !hasContentLoading && ( + + {match.params.id && ( + + {i18n._(`View User Details`)} + + )} + + ) + , diff --git a/awx/ui_next/src/screens/User/Users.jsx b/awx/ui_next/src/screens/User/Users.jsx index 35bdc5e30a..238bda2016 100644 --- a/awx/ui_next/src/screens/User/Users.jsx +++ b/awx/ui_next/src/screens/User/Users.jsx @@ -54,23 +54,24 @@ class Users extends Component { - } /> - ( - - {({ me }) => ( - - )} - - )} - /> - } /> + + + + + + {({ me }) => ( + + )} + + + + + );