From 1a3d452a2db18c1a69451869509c46d6eb08e074 Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Thu, 10 Nov 2016 11:45:24 -0500 Subject: [PATCH] Fix an auth issue in the browsable api Trying to get the object could raise an unhandleable permission error if the user wasn't logged in for certain views --- awx/api/renderers.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/awx/api/renderers.py b/awx/api/renderers.py index 2a4e17628e..a86865860a 100644 --- a/awx/api/renderers.py +++ b/awx/api/renderers.py @@ -44,8 +44,11 @@ class BrowsableAPIRenderer(renderers.BrowsableAPIRenderer): def get_rendered_html_form(self, data, view, method, request): # Never show auto-generated form (only raw form). obj = getattr(view, 'object', None) - if obj is None and hasattr(view, 'get_object') and hasattr(view, 'retrieve'): - obj = view.get_object() + if obj is None and hasattr(view, 'get_object') and hasattr(view, 'retrieve'):# and view.check_permissions(): + try: + obj = view.get_object() + except Exception: + obj = None with override_method(view, request, method) as request: if not self.show_form_for_method(view, method, request, obj): return