External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-15 07:57:29 -02:30
Code Issues Packages Projects Releases Wiki Activity

Peers_from_control_nodes requires listener port

Browse Source 
Adds validation and a unit test to ensure:

- peers_from_control_nodes=True should fail if
listener_port is not set
- peers_from_control_nodes=False should be NOOP if
listener_port is not set

Signed-off-by: Seth Foster <fosterbseth@gmail.com>
This commit is contained in:
Seth Foster
2024-01-23 17:42:33 -05:00
committed by Seth Foster
parent a4cf55bdba
commit 1b44bebed3
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
awx/main/tests/functional/api/test_instance_peers.py
View File

@@ -136,17 +136,24 @@ class TestPeers:
def test_peers_from_control_nodes_without_listener_port(self, admin_user, patch):
"""
patching with peers_from_control_nodes should not create a receptor address
if port is not defined
patching with peers_from_control_nodes=True should fail if listener_port is not set
patching with peers_from_control_nodes=False should be NOOP if listener_port is not set
"""
hop = Instance.objects.create(hostname='abc', node_type="hop")
patch(
resp = patch(
url=reverse('api:instance_detail', kwargs={'pk': hop.pk}),
data={"peers_from_control_nodes": True},
user=admin_user,
expect=400,
)
assert 'Cannot enable peers_from_control_nodes if listener_port is not set' in str(resp.data)
patch(
url=reverse('api:instance_detail', kwargs={'pk': hop.pk}),
data={"peers_from_control_nodes": False},
user=admin_user,
expect=200,
)
assert not ReceptorAddress.objects.filter(instance=hop).exists()
assert not ReceptorAddress.objects.filter(instance=hop, peers_from_control_nodes=False).exists()
def test_bidirectional_peering(self, admin_user, patch):
"""