CredentialAccess should check for the owner_role earlier

This commit is contained in:
Wayne Witzel III
2016-06-08 04:23:29 -04:00
parent 8319877a43
commit 1fb4a68047

View File

@@ -586,6 +586,7 @@ class CredentialAccess(BaseAccess):
if organization_pk: if organization_pk:
organization_obj = get_object_or_400(Organization, pk=organization_pk) organization_obj = get_object_or_400(Organization, pk=organization_pk)
return check_user_access(self.user, Organization, 'change', organization_obj, None) return check_user_access(self.user, Organization, 'change', organization_obj, None)
return False return False
@@ -595,9 +596,9 @@ class CredentialAccess(BaseAccess):
@check_superuser @check_superuser
def can_change(self, obj, data): def can_change(self, obj, data):
if not self.can_add(data): if self.user in obj.owner_role:
return False return True
return self.user in obj.owner_role return self.can_add(data)
def can_delete(self, obj): def can_delete(self, obj):
# Unassociated credentials may be marked deleted by anyone, though we # Unassociated credentials may be marked deleted by anyone, though we