From 2102c1ef0ab7e1040f570cb1ed0e1e71fb72c734 Mon Sep 17 00:00:00 2001 From: Ryan Petrello Date: Wed, 1 Aug 2018 17:36:55 -0400 Subject: [PATCH] fix a bug in multi-LDAP authentication see: https://github.com/ansible/tower/issues/2738 --- awx/sso/backends.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/awx/sso/backends.py b/awx/sso/backends.py index 93d7329d5f..0445c2302a 100644 --- a/awx/sso/backends.py +++ b/awx/sso/backends.py @@ -110,12 +110,13 @@ class LDAPBackend(BaseLDAPBackend): pass try: user = super(LDAPBackend, self).authenticate(username, password) - try: - user.ldap_user._get_groups().get_group_dns() - except ImproperlyConfigured: - logger.exception(_("Encountered an error populating user {} from LDAP").format(user.username)) - user.delete() - raise + if user and getattr(user, 'ldap_user', None): + try: + user.ldap_user._get_groups().get_group_dns() + except ImproperlyConfigured: + logger.exception(_("Encountered an error populating user {} from LDAP").format(user.username)) + user.delete() + raise return user except Exception: logger.exception("Encountered an error authenticating to LDAP")