External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-22 11:25:08 -02:30
Code Issues Packages Projects Releases Wiki Activity

Perform type checking on module_name and args for ad-hoc commands to

Browse Source 
satisfy qa.
This commit is contained in:
Matthew Jones
2015-05-29 14:55:15 -04:00
parent 79a8e541cd
commit 22ecb62179
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
awx/main/models/ad_hoc_commands.py
View File

@@ -101,12 +101,16 @@ class AdHocCommand(UnifiedJob):
return self.limit return self.limit
def clean_module_name(self): def clean_module_name(self):
if type(self.module_name) not in (str, unicode):
raise ValidationError("Invalid type for ad hoc command")
module_name = self.module_name.strip() or 'command' module_name = self.module_name.strip() or 'command'
if module_name not in settings.AD_HOC_COMMANDS: if module_name not in settings.AD_HOC_COMMANDS:
raise ValidationError('Unsupported module for ad hoc commands.') raise ValidationError('Unsupported module for ad hoc commands.')
return module_name return module_name
def clean_module_args(self): def clean_module_args(self):
if type(self.module_args) not in (str, unicode):
raise ValidationError("Invalid type for ad hoc command")
module_args = self.module_args module_args = self.module_args
if self.module_name in ('command', 'shell') and not module_args: if self.module_name in ('command', 'shell') and not module_args:
raise ValidationError('No argument passed to %s module.' % self.module_name) raise ValidationError('No argument passed to %s module.' % self.module_name)