mirror of
https://github.com/ansible/awx.git
synced 2026-02-23 14:05:59 -03:30
Add tests for Organization add view plus code refactoring.
This commit is contained in:
@@ -11,4 +11,41 @@ describe('<OrganizationAdd />', () => {
|
|||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
test('calls "onSelectChange" on dropdown select change', () => {
|
||||||
|
const spy = jest.spyOn(OrganizationAdd.prototype, 'onSelectChange');
|
||||||
|
const wrapper = mount(
|
||||||
|
<OrganizationAdd
|
||||||
|
match={{ path: '/organizations/add', url: '/organizations/add' }}
|
||||||
|
location={{ search: '', pathname: '/organizations/add' }}
|
||||||
|
/>
|
||||||
|
);
|
||||||
|
expect(spy).not.toHaveBeenCalled();
|
||||||
|
wrapper.find('select').simulate('change');
|
||||||
|
expect(spy).toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
test('calls "handleChange" when input values change', () => {
|
||||||
|
const spy = jest.spyOn(OrganizationAdd.prototype, 'handleChange');
|
||||||
|
const wrapper = mount(
|
||||||
|
<OrganizationAdd
|
||||||
|
match={{ path: '/organizations/add', url: '/organizations/add' }}
|
||||||
|
location={{ search: '', pathname: '/organizations/add' }}
|
||||||
|
/>
|
||||||
|
);
|
||||||
|
expect(spy).not.toHaveBeenCalled();
|
||||||
|
wrapper.find('input#add-org-form-name').simulate('change', {target: {value: 'foo'}});
|
||||||
|
wrapper.find('input#add-org-form-description').simulate('change', {target: {value: 'bar'}});
|
||||||
|
expect(spy).toHaveBeenCalledTimes(2);
|
||||||
|
});
|
||||||
|
test('calls "onSubmit" when Save button is clicked', () => {
|
||||||
|
const spy = jest.spyOn(OrganizationAdd.prototype, 'onSubmit');
|
||||||
|
const wrapper = mount(
|
||||||
|
<OrganizationAdd
|
||||||
|
match={{ path: '/organizations/add', url: '/organizations/add' }}
|
||||||
|
location={{ search: '', pathname: '/organizations/add' }}
|
||||||
|
/>
|
||||||
|
);
|
||||||
|
expect(spy).not.toHaveBeenCalled();
|
||||||
|
wrapper.find('button.at-C-SubmitButton').prop('onClick')();
|
||||||
|
expect(spy).toBeCalled();
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -22,7 +22,14 @@ import api from '../../../api';
|
|||||||
const { light } = PageSectionVariants;
|
const { light } = PageSectionVariants;
|
||||||
|
|
||||||
class OrganizationAdd extends React.Component {
|
class OrganizationAdd extends React.Component {
|
||||||
|
constructor(props) {
|
||||||
|
super(props);
|
||||||
|
|
||||||
|
this.handleChange = this.handleChange.bind(this);
|
||||||
|
this.onSelectChange = this.onSelectChange.bind(this);
|
||||||
|
this.onSubmit = this.onSubmit.bind(this);
|
||||||
|
this.resetForm = this.resetForm.bind(this);
|
||||||
|
}
|
||||||
state = {
|
state = {
|
||||||
name: '',
|
name: '',
|
||||||
description: '',
|
description: '',
|
||||||
@@ -31,31 +38,30 @@ class OrganizationAdd extends React.Component {
|
|||||||
post_endpoint: API_ORGANIZATIONS,
|
post_endpoint: API_ORGANIZATIONS,
|
||||||
};
|
};
|
||||||
|
|
||||||
onSelectChange = (value, _) => {
|
onSelectChange (value, _) {
|
||||||
this.setState({ ansible_environment: value });
|
this.setState({ ansible_environment: value });
|
||||||
};
|
};
|
||||||
|
resetForm() {
|
||||||
envs = [ // Placeholder for Ansible Environment Dropdown
|
|
||||||
{ ansible_environment: 'default', label: 'Select Ansible Environment', disabled: true },
|
|
||||||
{ ansible_environment: '1', label: '1', disabled: false },
|
|
||||||
{ ansible_environment: '2', label: '2', disabled: false },
|
|
||||||
{ ansible_environment: '3', label: '3', disabled: false }
|
|
||||||
];
|
|
||||||
resetForm = () => {
|
|
||||||
this.setState({
|
this.setState({
|
||||||
...this.state,
|
...this.state,
|
||||||
name: '',
|
name: '',
|
||||||
description: ''
|
description: ''
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
handleChange = (_, evt) => {
|
handleChange(_, evt) {
|
||||||
this.setState({ [evt.target.name]: evt.target.value });
|
this.setState({ [evt.target.name]: evt.target.value });
|
||||||
}
|
}
|
||||||
onSubmit = async () => {
|
async onSubmit() {
|
||||||
const data = Object.assign({}, { ...this.state });
|
const data = Object.assign({}, { ...this.state });
|
||||||
await api.post(API_ORGANIZATIONS, data);
|
await api.post(API_ORGANIZATIONS, data);
|
||||||
this.resetForm();
|
this.resetForm();
|
||||||
}
|
}
|
||||||
|
envs = [ // Placeholder for Ansible Environment Dropdown
|
||||||
|
{ ansible_environment: 'default', label: 'Select Ansible Environment', disabled: true },
|
||||||
|
{ ansible_environment: '1', label: '1', disabled: false },
|
||||||
|
{ ansible_environment: '2', label: '2', disabled: false },
|
||||||
|
{ ansible_environment: '3', label: '3', disabled: false }
|
||||||
|
];
|
||||||
render() {
|
render() {
|
||||||
const { name } = this.state;
|
const { name } = this.state;
|
||||||
const enabled = name.length > 0; // TODO: add better form validation
|
const enabled = name.length > 0; // TODO: add better form validation
|
||||||
@@ -101,9 +107,9 @@ class OrganizationAdd extends React.Component {
|
|||||||
/>
|
/>
|
||||||
</FormGroup>
|
</FormGroup>
|
||||||
<FormGroup label="Ansible Environment" fieldId="simple-form-instance-groups">
|
<FormGroup label="Ansible Environment" fieldId="simple-form-instance-groups">
|
||||||
<Select value={this.state.value} onChange={this.onSelectChange} aria-label="Select Input">
|
<Select value={this.state.ansible_environment} onChange={this.onSelectChange} aria-label="Select Input">
|
||||||
{this.envs.map((env, index) => (
|
{this.envs.map((env, index) => (
|
||||||
<SelectOption isDisabled={env.disabled} key={index} value={env.value} label={env.label} />
|
<SelectOption isDisabled={env.disabled} key={index} value={env.ansible_environment} label={env.label} />
|
||||||
))}
|
))}
|
||||||
</Select>
|
</Select>
|
||||||
</FormGroup>
|
</FormGroup>
|
||||||
@@ -111,7 +117,7 @@ class OrganizationAdd extends React.Component {
|
|||||||
<ActionGroup className="at-align-right">
|
<ActionGroup className="at-align-right">
|
||||||
<Toolbar>
|
<Toolbar>
|
||||||
<ToolbarGroup>
|
<ToolbarGroup>
|
||||||
<Button variant="primary" onClick={this.onSubmit} isDisabled={!enabled}>Save</Button>
|
<Button className="at-C-SubmitButton" variant="primary" onClick={this.onSubmit} isDisabled={!enabled}>Save</Button>
|
||||||
</ToolbarGroup>
|
</ToolbarGroup>
|
||||||
<ToolbarGroup>
|
<ToolbarGroup>
|
||||||
<Button variant="secondary">Cancel</Button>
|
<Button variant="secondary">Cancel</Button>
|
||||||
|
|||||||
Reference in New Issue
Block a user