Implement rbac and related unit tests for notifications

This commit is contained in:
Matthew Jones
2016-04-12 17:00:38 -04:00
parent 40731f6fc8
commit 28ffa57258
4 changed files with 139 additions and 9 deletions
+23
View File
@@ -36,6 +36,7 @@ from awx.main.models.organization import (
)
from awx.main.models.rbac import Role
from awx.main.models.notifications import Notifier
'''
Disable all django model signals.
@@ -174,6 +175,14 @@ def inventory(organization):
def label(organization):
return organization.labels.create(name="test-label", description="test-label-desc")
@pytest.fixture
def notifier(organization):
return Notifier.objects.create(name='test-notifier',
organization=organization,
notification_type="webhook",
notification_configuration=dict(url="http://localhost",
headers={"Test": "Header"}))
@pytest.fixture
def role():
return Role.objects.create(name='role')
@@ -255,6 +264,20 @@ def permissions():
'update':False, 'delete':False, 'scm_update':False, 'execute':False, 'use':True,},
}
@pytest.fixture
def notifier_factory(organization):
def n(name="test-notifier"):
try:
notifier = Notifier.objects.get(name=name)
except Notifier.DoesNotExist:
notifier = Notifier(name=name,
organization=organization,
notification_type="webhook",
notification_configuration=dict(url="http://localhost",
headers={"Test": "Header"}))
notifier.save()
return notifier
return n
@pytest.fixture
def post():
@@ -7,13 +7,6 @@ from awx.main.models.jobs import JobTemplate
from django.core.urlresolvers import reverse
@pytest.fixture
def notifier():
return Notifier.objects.create(name="test-notification",
notification_type="webhook",
notification_configuration=dict(url="http://localhost",
headers={"Test": "Header"}))
@pytest.mark.django_db
def test_get_notifier_list(get, user, notifier):
url = reverse('api:notifier_list')
@@ -0,0 +1,68 @@
import pytest
from awx.main.access import NotifierAccess
@pytest.mark.django_db
def test_notifier_get_queryset_orgmember(notifier, user):
access = NotifierAccess(user('user', False))
notifier.organization.member_role.members.add(user('user', False))
assert access.get_queryset().count() == 0
@pytest.mark.django_db
def test_notifier_get_queryset_nonorgmember(notifier, user):
access = NotifierAccess(user('user', False))
assert access.get_queryset().count() == 0
@pytest.mark.django_db
def test_notifier_get_queryset_su(notifier, user):
access = NotifierAccess(user('user', True))
assert access.get_queryset().count() == 1
@pytest.mark.django_db
def test_notifier_get_queryset_orgadmin(notifier, user):
access = NotifierAccess(user('admin', False))
notifier.organization.admin_role.members.add(user('admin', False))
assert access.get_queryset().count() == 1
@pytest.mark.django_db
def test_notifier_access_superuser(notifier, user, notifier_factory):
access = NotifierAccess(user('admin', True))
assert access.can_read(notifier)
assert access.can_change(notifier, None)
assert access.can_delete(notifier)
nf = notifier_factory("test-orphaned")
nf.organization = None
nf.save()
assert access.can_read(nf)
assert access.can_change(nf, None)
assert access.can_delete(nf)
@pytest.mark.django_db
def test_notifier_access_admin(notifier, user, organization_factory, notifier_factory):
adm = user('admin', False)
other_org = organization_factory('other')
present_org = organization_factory('present')
notifier.organization.admin_role.members.add(adm)
present_org.admin_role.members.add(adm)
access = NotifierAccess(user('admin', False))
assert not access.can_change(notifier, {'organization': other_org.id})
assert access.can_read(notifier)
assert access.can_change(notifier, None)
assert access.can_change(notifier, {'organization': present_org.id})
assert access.can_delete(notifier)
nf = notifier_factory("test-orphaned")
nf.organization = None
nf.save()
assert not access.can_read(nf)
assert not access.can_change(nf, None)
assert not access.can_delete(nf)
@pytest.mark.django_db
def test_notifier_access_org_user(notifier, user):
u = user('normal', False)
notifier.organization.member_role.members.add(u)
access = NotifierAccess(user('normal', False))
assert not access.can_read(notifier)
assert not access.can_change(notifier, None)
assert not access.can_delete(notifier)