mirror of
https://github.com/ansible/awx.git
synced 2026-10-29 22:03:20 -02:30
Fix awx-operator molecule test timeout being too tight (#16659)
* Fix awx-operator molecule test timeout being too tight The inline `timeout 20m` wrapping the molecule test run in the "Run test deployment with awx-operator" step (separate from the never-binding outer `timeout-minutes: 60`) isn't currently causing failures on this repo's runners (recent successful devel runs take 9.4-10.8m), but it's the same line that downstream (ansible/tower) had to bump to `timeout 54m` after its runs started legitimately taking 15-19.5m and getting killed with as little as ~30s of margin under 20m. Since downstream syncs this workflow from here, leaving it at 20m risks a future sync silently reverting the downstream fix. Raise it to 54m to match, well ahead of any regression in this repo's own runtime. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Liam Allen <lallen@redhat.com> * Raise awx-operator job-level timeout to fit the 54m inner timeout Job-level timeout-minutes covers the whole job cumulatively (checkout, image build, the deployment step, log collection, artifact upload), not just the deployment step. With the inner `timeout 54m` from the previous commit, a worst-case run (setup of ~6-8m plus the full 54m before the inner timeout fires) totals ~60-62m, which can trip the job-level 60m limit first and hard-cancel the job before "Collect awx-operator logs on failure" or the timed_out=true write ever execute - losing exactly the debug output this timeout-marker pattern exists to preserve. Raise job-level timeout-minutes to 75 to give headroom past the worst-case inner timeout. No change to the timed_out=true or conditional log-collection logic. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Liam Allen <lallen@redhat.com> --------- Signed-off-by: Liam Allen <lallen@redhat.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 5
parent
7bd5b0717c
commit
2d9e92e4cf
@@ -209,7 +209,7 @@ jobs:
|
||||
|
||||
awx-operator:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 60
|
||||
timeout-minutes: 75
|
||||
env:
|
||||
DEBUG_OUTPUT_DIR: /tmp/awx_operator_molecule_test
|
||||
steps:
|
||||
@@ -266,7 +266,7 @@ jobs:
|
||||
continue-on-error: true
|
||||
run: |
|
||||
set +e
|
||||
timeout 20m bash -elc '
|
||||
timeout 54m bash -elc '
|
||||
python -m pip install -r molecule/requirements.txt
|
||||
python -m pip install PyYAML # for awx/tools/scripts/rewrite-awx-operator-requirements.py
|
||||
$(realpath ../awx/tools/scripts/rewrite-awx-operator-requirements.py) molecule/requirements.yml $(realpath ../awx)
|
||||
|
||||
Reference in New Issue
Block a user