Removes code from serializer in favor to api call of Project.readDetails

Adds necessary tests.

awx/ui_next/src/screens/Template/JobTemplateDetail/JobTemplateDetail.jsx

@@ -196,12 +196,7 @@ class JobTemplateDetail extends Component {
             ) : (
               renderMissingDataDetail(i18n._(t`Project`))
             )}
-            {template.scm_branch && (
+            <Detail label={i18n._(t`SCM Branch`)} value={template.scm_branch} />
-              <Detail
-                label={i18n._(t`SCM Branch`)}
-                value={template.scm_branch}
-              />
-            )}
             <Detail label={i18n._(t`Playbook`)} value={playbook} />
             <Detail label={i18n._(t`Forks`)} value={forks || '0'} />
             <Detail label={i18n._(t`Limit`)} value={limit} />

awx/ui_next/src/screens/Template/JobTemplateEdit/JobTemplateEdit.test.jsx

@@ -161,6 +161,11 @@ describe('<JobTemplateEdit />', () => {
     JobTemplatesAPI.readInstanceGroups.mockReturnValue({
       data: { results: mockInstanceGroups },
     });
+    ProjectsAPI.readDetail.mockReturnValue({
+      id: 1,
+      allow_override: true,
+      name: 'foo',
+    });
   });
 
   afterEach(() => {

awx/ui_next/src/screens/Template/shared/JobTemplateForm.jsx

@@ -28,7 +28,7 @@ import {
   ProjectLookup,
   MultiCredentialsLookup,
 } from '@components/Lookup';
-import { JobTemplatesAPI } from '@api';
+import { JobTemplatesAPI, ProjectsAPI } from '@api';
 import LabelSelect from './LabelSelect';
 import PlaybookSelect from './PlaybookSelect';
 
@@ -81,16 +81,31 @@ class JobTemplateForm extends Component {
     this.loadRelatedInstanceGroups = this.loadRelatedInstanceGroups.bind(this);
     this.handleProjectUpdate = this.handleProjectUpdate.bind(this);
     this.setContentError = this.setContentError.bind(this);
+    this.fetchProject = this.fetchProject.bind(this);
   }
 
   componentDidMount() {
     const { validateField } = this.props;
     this.setState({ contentError: null, hasContentLoading: true });
     // TODO: determine when LabelSelect has finished loading labels
-    Promise.all([this.loadRelatedInstanceGroups()]).then(() => {
+    Promise.all([this.loadRelatedInstanceGroups(), this.fetchProject()]).then(
-      this.setState({ hasContentLoading: false });
+      () => {
-      validateField('project');
+        this.setState({ hasContentLoading: false });
-    });
+        validateField('project');
+      }
+    );
+  }
+
+  async fetchProject() {
+    const { project } = this.state;
+    if (project && project.id) {
+      try {
+        const { data } = await ProjectsAPI.readDetail(project.id);
+        this.setState({ project: data });
+      } catch (err) {
+        this.setState({ contentError: err });
+      }
+    }
   }
 
   async loadRelatedInstanceGroups() {

awx/ui_next/src/screens/Template/shared/JobTemplateForm.test.jsx

@@ -27,7 +27,6 @@ describe('<JobTemplateForm />', () => {
       project: {
         id: 3,
         name: 'qux',
-        allow_override: true,
       },
       labels: { results: [{ name: 'Sushi', id: 1 }, { name: 'Major', id: 2 }] },
       credentials: [
@@ -90,6 +89,11 @@ describe('<JobTemplateForm />', () => {
     ProjectsAPI.readPlaybooks.mockReturnValue({
       data: ['debug.yml'],
     });
+    ProjectsAPI.readDetail.mockReturnValue({
+      name: 'foo',
+      id: 1,
+      allow_override: true,
+    });
   });
 
   afterEach(() => {