Integrate Ansible core tower modules content into AWX

This commit includes all the changes involved in
converting the old Ansible Tower modules from commits
in Ansible core into the AWX collection that replaces it.
Also includes work needed to integrate it into the
AWX processes like tests, docs, and the Makefile.

Apply changes from content_collector tool

Add integrated module tests
  operate via run_module fixture
  add makefile target for them

Add flake8 target and fix flake8 errors

Update README

Make consolidated target for testing modules

awx_modules/test/awx/conftest.py

@@ -0,0 +1,121 @@
+import io
+import json
+import datetime
+import importlib
+from contextlib import redirect_stdout
+from unittest import mock
+
+from requests.models import Response
+
+import pytest
+
+from awx.main.tests.functional.conftest import _request
+from awx.main.models import Organization, Project, Inventory, Credential, CredentialType
+
+
+def sanitize_dict(din):
+    '''Sanitize Django response data to purge it of internal types
+    so it may be used to cast a requests response object
+    '''
+    if isinstance(din, (int, str, type(None), bool)):
+        return din  # native JSON types, no problem
+    elif isinstance(din, datetime.datetime):
+        return din.isoformat()
+    elif isinstance(din, list):
+        for i in range(len(din)):
+            din[i] = sanitize_dict(din[i])
+        return din
+    elif isinstance(din, dict):
+        for k in din.copy().keys():
+            din[k] = sanitize_dict(din[k])
+        return din
+    else:
+        return str(din)  # translation proxies often not string but stringlike
+
+
+@pytest.fixture
+def run_module():
+    def rf(module_name, module_params, request_user):
+
+        def new_request(self, method, url, **kwargs):
+            kwargs_copy = kwargs.copy()
+            if 'data' in kwargs:
+                kwargs_copy['data'] = json.loads(kwargs['data'])
+
+            # make request
+            rf = _request(method.lower())
+            django_response = rf(url, user=request_user, expect=None, **kwargs_copy)
+
+            # requests library response object is different from the Django response, but they are the same concept
+            # this converts the Django response object into a requests response object for consumption
+            resp = Response()
+            py_data = django_response.data
+            sanitize_dict(py_data)
+            resp._content = bytes(json.dumps(django_response.data), encoding='utf8')
+            resp.status_code = django_response.status_code
+            return resp
+
+        stdout_buffer = io.StringIO()
+        # Requies specific PYTHONPATH, see docs
+        # Note that a proper Ansiballz explosion of the modules will have an import path like:
+        # ansible_collections.awx.awx.plugins.modules.{}
+        # We should consider supporting that in the future
+        resource_module = importlib.import_module('plugins.modules.{}'.format(module_name))
+
+        # Ansible params can be passed as an invocation argument or over stdin
+        # this short circuits within the AnsibleModule interface
+        def mock_load_params(self):
+            self.params = module_params
+
+        with mock.patch.object(resource_module.TowerModule, '_load_params', new=mock_load_params):
+            # Call the test utility (like a mock server) instead of issuing HTTP requests
+            with mock.patch('tower_cli.api.Session.request', new=new_request):
+                # Ansible modules return data to the mothership over stdout
+                with redirect_stdout(stdout_buffer):
+                    try:
+                        resource_module.main()
+                    except SystemExit:
+                        pass  # A system exit indicates successful execution
+
+        module_stdout = stdout_buffer.getvalue().strip()
+        result = json.loads(module_stdout)
+        return result
+
+    return rf
+
+
+@pytest.fixture
+def organization():
+    return Organization.objects.create(name='Default')
+
+
+@pytest.fixture
+def project(organization):
+    return Project.objects.create(
+        name="test-proj",
+        description="test-proj-desc",
+        organization=organization,
+        playbook_files=['helloworld.yml'],
+        local_path='_92__test_proj',
+        scm_revision='1234567890123456789012345678901234567890',
+        scm_url='localhost',
+        scm_type='git'
+    )
+
+
+@pytest.fixture
+def inventory(organization):
+    return Inventory.objects.create(
+        name='test-inv',
+        organization=organization
+    )
+
+
+@pytest.fixture
+def machine_credential(organization):
+    ssh_type = CredentialType.defaults['ssh']()
+    ssh_type.save()
+    return Credential.objects.create(
+        credential_type=ssh_type, name='machine-cred',
+        inputs={'username': 'test_user', 'password': 'pas4word'}
+    )

awx_modules/test/awx/test_job_template.py

@@ -0,0 +1,59 @@
+import pytest
+
+from awx.main.models import JobTemplate
+
+
+@pytest.mark.django_db
+def test_create_job_template(run_module, admin_user, project, inventory):
+
+    module_args = {
+        'name': 'foo', 'playbook': 'helloworld.yml',
+        'project': project.name, 'inventory': inventory.name,
+        'job_type': 'run',
+        'state': 'present'
+    }
+
+    result = run_module('tower_job_template', module_args, admin_user)
+
+    jt = JobTemplate.objects.get(name='foo')
+
+    assert result == {
+        "job_template": "foo",
+        "state": "present",
+        "id": jt.id,
+        "changed": True,
+        "invocation": {
+            "module_args": module_args
+        }
+    }
+
+    assert jt.project_id == project.id
+    assert jt.inventory_id == inventory.id
+
+
+@pytest.mark.django_db
+@pytest.mark.xfail(reason='Known limitation and needs to be fixed.')
+def test_create_job_template_with_old_machine_cred(run_module, admin_user, project, inventory, machine_credential):
+
+    module_args = {
+        'name': 'foo', 'playbook': 'helloworld.yml',
+        'project': project.name, 'inventory': inventory.name, 'credential': machine_credential.name,
+        'job_type': 'run',
+        'state': 'present'
+    }
+
+    result = run_module('tower_job_template', module_args, admin_user)
+
+    jt = JobTemplate.objects.get(name='foo')
+
+    assert result == {
+        "job_template": "foo",
+        "state": "present",
+        "id": jt.id,
+        "changed": True,
+        "invocation": {
+            "module_args": module_args
+        }
+    }
+
+    assert machine_credential.id in [cred.pk for cred in jt.credentials.all()]

awx_modules/test/awx/test_organization.py

@@ -0,0 +1,25 @@
+import pytest
+
+from awx.main.models import Organization
+
+
+@pytest.mark.django_db
+def test_create_organization(run_module, admin_user):
+
+    module_args = {'name': 'foo', 'description': 'barfoo', 'state': 'present'}
+
+    result = run_module('tower_organization', module_args, admin_user)
+
+    org = Organization.objects.get(name='foo')
+
+    assert result == {
+        "organization": "foo",
+        "state": "present",
+        "id": org.id,
+        "changed": True,
+        "invocation": {
+            "module_args": module_args
+        }
+    }
+
+    assert org.description == 'barfoo'