From 30605051108bf21b758d7e444834e100bfe05445 Mon Sep 17 00:00:00 2001
From: Shane McDonald <me@shanemcd.com>
Date: Tue, 31 Mar 2020 12:59:32 -0400
Subject: [PATCH] Switch from StatefulSet to Deployment

We can do this now that we dropped RabbitMQ.
---
 installer/roles/kubernetes/tasks/main.yml              | 8 ++++----
 installer/roles/kubernetes/templates/deployment.yml.j2 | 7 +++----
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/installer/roles/kubernetes/tasks/main.yml b/installer/roles/kubernetes/tasks/main.yml
index f65098c589..024cb0a3eb 100644
--- a/installer/roles/kubernetes/tasks/main.yml
+++ b/installer/roles/kubernetes/tasks/main.yml
@@ -30,7 +30,7 @@
     kubectl_or_oc: "{{ openshift_oc_bin if openshift_oc_bin is defined else 'kubectl' }}"
 
 - set_fact:
-    deployment_object: "sts"
+    deployment_object: "deployment"
 
 - name: Record deployment size
   shell: |
@@ -137,7 +137,7 @@
       shell: |
         POD=$({{ kubectl_or_oc }} -n {{ kubernetes_namespace }} \
           get pods -l=name=postgresql --field-selector status.phase=Running -o jsonpath="{.items[0].metadata.name}")
-        oc exec $POD -n {{ kubernetes_namespace }} -- bash -c "psql -tAc 'select version()'"
+        {{ kubectl_or_oc }} exec $POD -n {{ kubernetes_namespace }} -- bash -c "psql -tAc 'select version()'"
       register: pg_version
     - name: Upgrade postgres if necessary
       block:
@@ -200,9 +200,9 @@
       when: kubernetes_web_image is not defined
   when: docker_registry is defined
 
-- name: Determine StatefulSet api version
+- name: Determine Deployment api version
   set_fact:
-    kubernetes_statefulset_api_version: "{{ 'apps/v1' if kube_api_version is version('1.9', '>=') else 'apps/v1beta1' }}"
+    kubernetes_deployment_api_version: "{{ 'apps/v1' if kube_api_version is version('1.9', '>=') else 'apps/v1beta1' }}"
 
 - name: Render deployment templates
   set_fact:
diff --git a/installer/roles/kubernetes/templates/deployment.yml.j2 b/installer/roles/kubernetes/templates/deployment.yml.j2
index 44b778f009..47811f1f08 100644
--- a/installer/roles/kubernetes/templates/deployment.yml.j2
+++ b/installer/roles/kubernetes/templates/deployment.yml.j2
@@ -16,8 +16,8 @@ imagePullSecrets:
 {% endif %}
 
 ---
-apiVersion: {{ kubernetes_statefulset_api_version }}
-kind: StatefulSet
+apiVersion: {{ kubernetes_deployment_api_version }}
+kind: Deployment
 metadata:
   name: {{ kubernetes_deployment_name }}
   namespace: {{ kubernetes_namespace }}
@@ -26,9 +26,8 @@ metadata:
     app: {{ kubernetes_deployment_name }}
 {% endif %}
 spec:
-  serviceName: {{ kubernetes_deployment_name }}
   replicas: 1
-{% if kubernetes_statefulset_api_version == "apps/v1" %}
+{% if kubernetes_deployment_api_version == "apps/v1" %}
   selector:
     matchLabels:
       app: {{ kubernetes_deployment_name }}