mirror of
https://github.com/ansible/awx.git
synced 2026-03-01 08:48:46 -03:30
Merge pull request #10053 from AlanCoding/dropsies
Intentionally drop job event websocket messages in excess of 30 per second (configurable) SUMMARY The UI no longer follows the latest job events from websocket messages. Because of that, there's no reason to send messages for all events if the job event rate is high. I used 30 because this is the number of events that I guesstimate will show in one page in the UI. Needs the setting added in the UI. This adds skip_websocket_message to event event_data. We could promote it to a top-level key for job events, if that is preferable aesthetically. Doing this allows us to test this feature without having to connect a websocket client. Ping @mabashian @chrismeyersfsu ISSUE TYPE Feature Pull Request COMPONENT NAME API UI ADDITIONAL INFORMATION Scenario walkthrough: a job is producing 1,000 events per second. User launches it, the screen fills up in, say 1/4 of a second. The scrollbar indicates content beyond the bottom of the screen. Now, for 3/4ths of a second, the scrollbar stays still. After that, it updates the scrollbar to the current line number that the job is on. The scrollbar continues to update the length of the output effectively once per second. Reviewed-by: Alan Rominger <arominge@redhat.com> Reviewed-by: Chris Meyers <None> Reviewed-by: Jake McDermott <yo@jakemcdermott.me>
This commit is contained in:
@@ -197,8 +197,9 @@ UI_LIVE_UPDATES_ENABLED = True
|
||||
# beyond this limit and the value will be removed
|
||||
MAX_EVENT_RES_DATA = 700000
|
||||
|
||||
# Note: This setting may be overridden by database settings.
|
||||
# Note: These settings may be overridden by database settings.
|
||||
EVENT_STDOUT_MAX_BYTES_DISPLAY = 1024
|
||||
MAX_WEBSOCKET_EVENT_RATE = 30
|
||||
|
||||
# The amount of time before a stdout file is expired and removed locally
|
||||
# Note that this can be recreated if the stdout is downloaded
|
||||
|
||||
Reference in New Issue
Block a user