Merge pull request #2840 from anoek/test-porting

Ported several old tests to our new test system

awx/main/tests/functional/api/test_organizations.py

@@ -0,0 +1,190 @@
+# Copyright (c) 2015 Ansible, Inc.
+# All Rights Reserved.
+
+# Python
+import pytest
+import mock
+
+
+# Django
+from django.core.urlresolvers import reverse
+
+# AWX
+from awx.main.models import * # noqa
+
+
+@pytest.mark.django_db
+def test_organization_list_access_tests(options, head, get, admin, alice):
+    options(reverse('api:organization_list'), user=admin, expect=200)
+    head(reverse('api:organization_list'), user=admin, expect=200)
+    get(reverse('api:organization_list'), user=admin, expect=200)
+    options(reverse('api:organization_list'), user=alice, expect=200)
+    head(reverse('api:organization_list'), user=alice, expect=200)
+    get(reverse('api:organization_list'), user=alice, expect=200)
+    options(reverse('api:organization_list'), user=None, expect=401)
+    head(reverse('api:organization_list'), user=None, expect=401)
+    get(reverse('api:organization_list'), user=None, expect=401)
+
+
+@pytest.mark.django_db
+def test_organization_access_tests(organization, get, admin, alice, bob):
+    organization.member_role.members.add(alice)
+    get(reverse('api:organization_detail', args=(organization.id,)), user=admin, expect=200)
+    get(reverse('api:organization_detail', args=(organization.id,)), user=alice, expect=200)
+    get(reverse('api:organization_detail', args=(organization.id,)), user=bob, expect=403)
+    get(reverse('api:organization_detail', args=(organization.id,)), user=None, expect=401)
+
+
+@pytest.mark.django_db
+def test_organization_list_integrity(organization, get, admin, alice):
+    res = get(reverse('api:organization_list'), user=admin)
+    for field in ['id', 'url', 'name', 'description', 'created']:
+        assert field in res.data['results'][0]
+
+
+@pytest.mark.django_db
+def test_organization_list_visibility(organizations, get, admin, alice):
+    orgs = organizations(2)
+
+    res = get(reverse('api:organization_list'), user=admin)
+    assert res.data['count'] == 2
+    assert len(res.data['results']) == 2
+
+    res = get(reverse('api:organization_list'), user=alice)
+    assert res.data['count'] == 0
+
+    orgs[1].member_role.members.add(alice)
+
+    res = get(reverse('api:organization_list'), user=alice)
+    assert res.data['count'] == 1
+    assert len(res.data['results']) == 1
+    assert res.data['results'][0]['id'] == orgs[1].id
+
+
+@pytest.mark.django_db
+def test_organization_project_list(organization, project_factory, get, alice, bob, rando):
+    prj1 = project_factory('project-one')
+    project_factory('project-two')
+    organization.admin_role.members.add(alice)
+    organization.member_role.members.add(bob)
+    prj1.use_role.members.add(bob)
+    assert get(reverse('api:organization_projects_list', args=(organization.id,)), user=alice).data['count'] == 2
+    assert get(reverse('api:organization_projects_list', args=(organization.id,)), user=bob).data['count'] == 1
+    assert get(reverse('api:organization_projects_list', args=(organization.id,)), user=rando).status_code == 403
+
+
+@pytest.mark.django_db
+def test_organization_user_list(organization, get, admin, alice, bob):
+    organization.admin_role.members.add(alice)
+    organization.member_role.members.add(alice)
+    organization.member_role.members.add(bob)
+    assert get(reverse('api:organization_users_list', args=(organization.id,)), user=admin).data['count'] == 2
+    assert get(reverse('api:organization_users_list', args=(organization.id,)), user=alice).data['count'] == 2
+    assert get(reverse('api:organization_users_list', args=(organization.id,)), user=bob).data['count'] == 2
+    assert get(reverse('api:organization_admins_list', args=(organization.id,)), user=admin).data['count'] == 1
+    assert get(reverse('api:organization_admins_list', args=(organization.id,)), user=alice).data['count'] == 1
+    assert get(reverse('api:organization_admins_list', args=(organization.id,)), user=bob).data['count'] == 1
+
+
+@pytest.mark.django_db
+def test_organization_inventory_list(organization, inventory_factory, get, alice, bob, rando):
+    inv1 = inventory_factory('inventory-one')
+    inventory_factory('inventory-two')
+    organization.admin_role.members.add(alice)
+    organization.member_role.members.add(bob)
+    inv1.use_role.members.add(bob)
+    assert get(reverse('api:organization_inventories_list', args=(organization.id,)), user=alice).data['count'] == 2
+    assert get(reverse('api:organization_inventories_list', args=(organization.id,)), user=bob).data['count'] == 1
+    get(reverse('api:organization_inventories_list', args=(organization.id,)), user=rando, expect=403)
+
+
+@pytest.mark.django_db
+@mock.patch('awx.api.views.feature_enabled', lambda feature,bypass_db=None: True)
+def test_create_organization(post, admin, alice):
+    new_org = {
+        'name': 'new org',
+        'description': 'my description'
+    }
+    res = post(reverse('api:organization_list'), new_org, user=admin, expect=201)
+    assert res.data['name'] == new_org['name']
+    res = post(reverse('api:organization_list'), new_org, user=admin, expect=400)
+
+
+@pytest.mark.django_db
+@mock.patch('awx.api.views.feature_enabled', lambda feature,bypass_db=None: True)
+def test_create_organization_xfail(post, alice):
+    new_org = {
+        'name': 'new org',
+        'description': 'my description'
+    }
+    post(reverse('api:organization_list'), new_org, user=alice, expect=403)
+
+
+@pytest.mark.django_db
+def test_add_user_to_organization(post, organization, alice, bob):
+    organization.admin_role.members.add(alice)
+    post(reverse('api:organization_users_list', args=(organization.id,)), {'id': bob.id}, user=alice, expect=204)
+    assert bob in organization.member_role
+    post(reverse('api:organization_users_list', args=(organization.id,)), {'id': bob.id, 'disassociate': True} , user=alice, expect=204)
+    assert bob not in organization.member_role
+
+
+@pytest.mark.django_db
+def test_add_user_to_organization_xfail(post, organization, alice, bob):
+    organization.member_role.members.add(alice)
+    post(reverse('api:organization_users_list', args=(organization.id,)), {'id': bob.id}, user=alice, expect=403)
+
+
+@pytest.mark.django_db
+def test_add_admin_to_organization(post, organization, alice, bob):
+    organization.admin_role.members.add(alice)
+    post(reverse('api:organization_admins_list', args=(organization.id,)), {'id': bob.id}, user=alice, expect=204)
+    assert bob in organization.admin_role
+    assert bob in organization.member_role
+    post(reverse('api:organization_admins_list', args=(organization.id,)), {'id': bob.id, 'disassociate': True} , user=alice, expect=204)
+    assert bob not in organization.admin_role
+    assert bob not in organization.member_role
+
+
+@pytest.mark.django_db
+def test_add_admin_to_organization_xfail(post, organization, alice, bob):
+    organization.member_role.members.add(alice)
+    post(reverse('api:organization_admins_list', args=(organization.id,)), {'id': bob.id}, user=alice, expect=403)
+
+
+@pytest.mark.django_db
+def test_update_organization(get, put, organization, alice, bob):
+    organization.admin_role.members.add(alice)
+    data = get(reverse('api:organization_detail', args=(organization.id,)), user=alice, expect=200).data
+    data['description'] = 'hi'
+    put(reverse('api:organization_detail', args=(organization.id,)), data, user=alice, expect=200)
+    organization.refresh_from_db()
+    assert organization.description == 'hi'
+    data['description'] = 'bye'
+    put(reverse('api:organization_detail', args=(organization.id,)), data, user=bob, expect=403)
+
+
+@pytest.mark.django_db
+@mock.patch('awx.main.access.BaseAccess.check_license', lambda *a, **kw: True)
+def test_delete_organization(delete, organization, admin):
+    delete(reverse('api:organization_detail', args=(organization.id,)), user=admin, expect=204)
+
+
+@pytest.mark.django_db
+@mock.patch('awx.main.access.BaseAccess.check_license', lambda *a, **kw: True)
+def test_delete_organization2(delete, organization, alice):
+    organization.admin_role.members.add(alice)
+    delete(reverse('api:organization_detail', args=(organization.id,)), user=alice, expect=204)
+
+
+@pytest.mark.django_db
+@mock.patch('awx.main.access.BaseAccess.check_license', lambda *a, **kw: True)
+def test_delete_organization_xfail1(delete, organization, alice):
+    organization.member_role.members.add(alice)
+    delete(reverse('api:organization_detail', args=(organization.id,)), user=alice, expect=403)
+
+
+@pytest.mark.django_db
+@mock.patch('awx.main.access.BaseAccess.check_license', lambda *a, **kw: True)
+def test_delete_organization_xfail2(delete, organization):
+    delete(reverse('api:organization_detail', args=(organization.id,)), user=None, expect=401)

awx/main/tests/functional/api/test_unified_jobs_view.py

@@ -1,8 +1,83 @@
 import pytest
 
-from awx.main.models import UnifiedJob
 from django.core.urlresolvers import reverse
 
+from awx.main.models import UnifiedJob, ProjectUpdate
+from awx.main.tests.base import URI
+
+
+TEST_STDOUTS = []
+uri = URI(scheme="https", username="Dhh3U47nmC26xk9PKscV", password="PXPfWW8YzYrgS@E5NbQ2H@", host="github.ginger.com/theirrepo.git/info/refs")
+TEST_STDOUTS.append({
+    'description': 'uri in a plain text document',
+    'uri' : uri,
+    'text' : 'hello world %s goodbye world' % uri,
+    'occurrences' : 1
+})
+
+uri = URI(scheme="https", username="applepie@@@", password="thatyouknow@@@@", host="github.ginger.com/theirrepo.git/info/refs")
+TEST_STDOUTS.append({
+    'description': 'uri appears twice in a multiline plain text document',
+    'uri' : uri,
+    'text' : 'hello world %s \n\nyoyo\n\nhello\n%s' % (uri, uri),
+    'occurrences' : 2
+})
+
+
+
+@pytest.fixture
+def test_cases(project):
+    ret = []
+    for e in TEST_STDOUTS:
+        e['project'] = ProjectUpdate(project=project)
+        e['project'].result_stdout_text = e['text']
+        e['project'].save()
+        ret.append(e)
+    return ret
+
+@pytest.fixture
+def negative_test_cases(job_factory):
+    ret = []
+    for e in TEST_STDOUTS:
+        e['job'] = job_factory()
+        e['job'].result_stdout_text = e['text']
+        e['job'].save()
+        ret.append(e)
+    return ret
+
+
+formats = [
+    ('json', 'application/json'),
+    ('ansi', 'text/plain'),
+    ('txt', 'text/plain'),
+    ('html', 'text/html'),
+]
+
+@pytest.mark.parametrize("format,content_type", formats)
+@pytest.mark.django_db
+def test_project_update_redaction_enabled(get, format, content_type, test_cases, admin):
+    for test_data in test_cases:
+        job = test_data['project']
+        response = get(reverse("api:project_update_stdout", args=(job.pk,)) + "?format=" + format, user=admin, expect=200, accept=content_type)
+        assert content_type in response['CONTENT-TYPE']
+        assert response.data is not None
+        content = response.data['content'] if format == 'json' else response.data
+        assert test_data['uri'].username not in content
+        assert test_data['uri'].password not in content
+        assert content.count(test_data['uri'].host) == test_data['occurrences']
+
+@pytest.mark.parametrize("format,content_type", formats)
+@pytest.mark.django_db
+def test_job_redaction_disabled(get, format, content_type, negative_test_cases, admin):
+    for test_data in negative_test_cases:
+        job = test_data['job']
+        response = get(reverse("api:job_stdout", args=(job.pk,)) + "?format=" + format, user=admin, expect=200, format=format)
+        content = response.data['content'] if format == 'json' else response.data
+        assert response.data is not None
+        assert test_data['uri'].username in content
+        assert test_data['uri'].password in content
+
+
 @pytest.mark.django_db
 def test_options_fields_choices(instance, options, user):
 
@@ -15,3 +90,4 @@ def test_options_fields_choices(instance, options, user):
     assert 'choice' == response.data['actions']['GET']['status']['type']
     assert UnifiedJob.STATUS_CHOICES == response.data['actions']['GET']['status']['choices']
 
+

awx/main/tests/functional/conftest.py

@@ -124,6 +124,12 @@ def project_factory(organization):
         return prj
     return factory
 
+@pytest.fixture
+def job_factory(job_template, admin):
+    def factory(job_template=job_template, initial_state='new', created_by=admin):
+        return job_template.create_job(created_by=created_by, status=initial_state)
+    return factory
+
 @pytest.fixture
 def team_factory(organization):
     def factory(name):
@@ -292,17 +298,23 @@ def permissions():
                  'update':False, 'delete':False, 'scm_update':False, 'execute':False, 'use':True,},
     }
 
-@pytest.fixture
-def post():
-    def rf(url, data, user=None, middleware=None, expect=None, **kwargs):
-        view, view_args, view_kwargs = resolve(urlparse(url)[2])
+
+def _request(verb):
+    def rf(url, data_or_user=None, user=None, middleware=None, expect=None, **kwargs):
+        if type(data_or_user) is User and user is None:
+            user = data_or_user
+        elif 'data' not in kwargs:
+            kwargs['data'] = data_or_user
         if 'format' not in kwargs:
             kwargs['format'] = 'json'
-        request = APIRequestFactory().post(url, data, **kwargs)
+
+        view, view_args, view_kwargs = resolve(urlparse(url)[2])
+        request = getattr(APIRequestFactory(), verb)(url, **kwargs)
         if middleware:
             middleware.process_request(request)
         if user:
             force_authenticate(request, user=user)
+
         response = view(request, *view_args, **view_kwargs)
         if middleware:
             middleware.process_response(request, response)
@@ -310,134 +322,37 @@ def post():
             if response.status_code != expect:
                 print(response.data)
             assert response.status_code == expect
+        response.render()
         return response
     return rf
 
+@pytest.fixture
+def post():
+    return _request('post')
+
 @pytest.fixture
 def get():
-    def rf(url, user=None, middleware=None, expect=None, **kwargs):
-        view, view_args, view_kwargs = resolve(urlparse(url)[2])
-        if 'format' not in kwargs:
-            kwargs['format'] = 'json'
-        request = APIRequestFactory().get(url, **kwargs)
-        if middleware:
-            middleware.process_request(request)
-        if user:
-            force_authenticate(request, user=user)
-        response = view(request, *view_args, **view_kwargs)
-        if middleware:
-            middleware.process_response(request, response)
-        if expect:
-            if response.status_code != expect:
-                print(response.data)
-            assert response.status_code == expect
-        return response
-    return rf
+    return _request('get')
 
 @pytest.fixture
 def put():
-    def rf(url, data, user=None, middleware=None, expect=None, **kwargs):
-        view, view_args, view_kwargs = resolve(urlparse(url)[2])
-        if 'format' not in kwargs:
-            kwargs['format'] = 'json'
-        request = APIRequestFactory().put(url, data, **kwargs)
-        if middleware:
-            middleware.process_request(request)
-        if user:
-            force_authenticate(request, user=user)
-        response = view(request, *view_args, **view_kwargs)
-        if middleware:
-            middleware.process_response(request, response)
-        if expect:
-            if response.status_code != expect:
-                print(response.data)
-            assert response.status_code == expect
-        return response
-    return rf
+    return _request('put')
 
 @pytest.fixture
 def patch():
-    def rf(url, data, user=None, middleware=None, expect=None, **kwargs):
-        view, view_args, view_kwargs = resolve(urlparse(url)[2])
-        if 'format' not in kwargs:
-            kwargs['format'] = 'json'
-        request = APIRequestFactory().patch(url, data, **kwargs)
-        if middleware:
-            middleware.process_request(request)
-        if user:
-            force_authenticate(request, user=user)
-        response = view(request, *view_args, **view_kwargs)
-        if middleware:
-            middleware.process_response(request, response)
-        if expect:
-            if response.status_code != expect:
-                print(response.data)
-            assert response.status_code == expect
-        return response
-    return rf
+    return _request('patch')
 
 @pytest.fixture
 def delete():
-    def rf(url, user=None, middleware=None, expect=None, **kwargs):
-        view, view_args, view_kwargs = resolve(urlparse(url)[2])
-        if 'format' not in kwargs:
-            kwargs['format'] = 'json'
-        request = APIRequestFactory().delete(url, **kwargs)
-        if middleware:
-            middleware.process_request(request)
-        if user:
-            force_authenticate(request, user=user)
-        response = view(request, *view_args, **view_kwargs)
-        if middleware:
-            middleware.process_response(request, response)
-        if expect:
-            if response.status_code != expect:
-                print(response.data)
-            assert response.status_code == expect
-        return response
-    return rf
+    return _request('delete')
 
 @pytest.fixture
 def head():
-    def rf(url, user=None, middleware=None, expect=None, **kwargs):
-        view, view_args, view_kwargs = resolve(urlparse(url)[2])
-        if 'format' not in kwargs:
-            kwargs['format'] = 'json'
-        request = APIRequestFactory().head(url, **kwargs)
-        if middleware:
-            middleware.process_request(request)
-        if user:
-            force_authenticate(request, user=user)
-        response = view(request, *view_args, **view_kwargs)
-        if middleware:
-            middleware.process_response(request, response)
-        if expect:
-            if response.status_code != expect:
-                print(response.data)
-            assert response.status_code == expect
-        return response
-    return rf
+    return _request('head')
 
 @pytest.fixture
 def options():
-    def rf(url, data, user=None, middleware=None, expect=None, **kwargs):
-        view, view_args, view_kwargs = resolve(urlparse(url)[2])
-        if 'format' not in kwargs:
-            kwargs['format'] = 'json'
-        request = APIRequestFactory().options(url, data, **kwargs)
-        if middleware:
-            middleware.process_request(request)
-        if user:
-            force_authenticate(request, user=user)
-        response = view(request, *view_args, **view_kwargs)
-        if middleware:
-            middleware.process_response(request, response)
-        if expect:
-            if response.status_code != expect:
-                print(response.data)
-            assert response.status_code == expect
-        return response
-    return rf
+    return _request('options')
 
 
 

awx/main/tests/functional/core/test_licenses.py

@@ -0,0 +1,132 @@
+# Copyright (c) 2015 Ansible, Inc.
+# All Rights Reserved.
+
+import json
+import mock
+import os
+import tempfile
+import time
+import pytest
+from datetime import datetime
+
+from awx.main.models import Host
+from awx.main.task_engine import TaskSerializer, TaskEngager
+
+
+@pytest.mark.django_db
+def test_license_writer(inventory, admin):
+    writer = TaskEngager(
+        company_name='acmecorp',
+        contact_name='Michael DeHaan',
+        contact_email='michael@ansibleworks.com',
+        license_date=25000, # seconds since epoch
+        instance_count=500)
+
+    data = writer.get_data()
+
+    Host.objects.bulk_create(
+        [
+            Host(
+                name='host.%d' % n,
+                inventory=inventory,
+                created_by=admin,
+                modified=datetime.now(),
+                created=datetime.now())
+            for n in range(12)
+        ]
+    )
+
+    assert data['instance_count'] == 500
+    assert data['contact_name'] == 'Michael DeHaan'
+    assert data['contact_email'] == 'michael@ansibleworks.com'
+    assert data['license_date'] == 25000
+    assert data['license_key'] == "11bae31f31c6a6cdcb483a278cdbe98bd8ac5761acd7163a50090b0f098b3a13"
+
+    strdata = writer.get_string()
+    strdata_loaded = json.loads(strdata)
+    assert strdata_loaded == data
+
+    reader = TaskSerializer()
+
+    vdata = reader.from_string(strdata)
+
+    assert vdata['available_instances'] == 500
+    assert vdata['current_instances'] == 12
+    assert vdata['free_instances'] == 488
+    assert vdata['date_warning'] is True
+    assert vdata['date_expired'] is True
+    assert vdata['license_date'] == 25000
+    assert vdata['time_remaining'] < 0
+    assert vdata['valid_key'] is True
+    assert vdata['compliant'] is False
+    assert vdata['subscription_name']
+
+@pytest.mark.django_db
+def test_expired_licenses():
+    reader = TaskSerializer()
+    writer = TaskEngager(
+        company_name='Tower',
+        contact_name='Tower Admin',
+        contact_email='tower@ansible.com',
+        license_date=int(time.time() - 3600),
+        instance_count=100,
+        trial=True)
+    strdata = writer.get_string()
+    vdata = reader.from_string(strdata)
+
+    assert vdata['compliant'] is False
+    assert vdata['grace_period_remaining'] < 0
+
+    writer = TaskEngager(
+        company_name='Tower',
+        contact_name='Tower Admin',
+        contact_email='tower@ansible.com',
+        license_date=int(time.time() - 2592001),
+        instance_count=100,
+        trial=False)
+    strdata = writer.get_string()
+    vdata = reader.from_string(strdata)
+
+    assert vdata['compliant'] is False
+    assert vdata['grace_period_remaining'] < 0
+
+    writer = TaskEngager(
+        company_name='Tower',
+        contact_name='Tower Admin',
+        contact_email='tower@ansible.com',
+        license_date=int(time.time() - 3600),
+        instance_count=100,
+        trial=False)
+    strdata = writer.get_string()
+    vdata = reader.from_string(strdata)
+
+    assert vdata['compliant'] is False
+    assert vdata['grace_period_remaining'] > 0
+
+@pytest.mark.django_db
+def test_aws_license():
+    os.environ['AWX_LICENSE_FILE'] = 'non-existent-license-file.json'
+
+    h, path = tempfile.mkstemp()
+    with os.fdopen(h, 'w') as f:
+        json.dump({'instance_count': 100}, f)
+
+    def fetch_ami(_self):
+        _self.attributes['ami-id'] = 'ami-00000000'
+        return True
+
+    def fetch_instance(_self):
+        _self.attributes['instance-id'] = 'i-00000000'
+        return True
+
+    with mock.patch('awx.main.task_engine.TEMPORARY_TASK_FILE', path):
+        with mock.patch('awx.main.task_engine.TemporaryTaskEngine.fetch_ami', fetch_ami):
+            with mock.patch('awx.main.task_engine.TemporaryTaskEngine.fetch_instance', fetch_instance):
+                reader = TaskSerializer()
+                license = reader.from_file()
+                assert license['is_aws']
+                assert license['time_remaining']
+                assert license['free_instances'] > 0
+                assert license['grace_period_remaining'] > 0
+
+    os.unlink(path)

awx/main/tests/functional/test_auth_token_limit.py

@@ -0,0 +1,39 @@
+import pytest
+from datetime import timedelta
+
+from django.utils.timezone import now as tz_now
+from django.test.utils import override_settings
+
+from awx.main.models import AuthToken, User
+
+
+@override_settings(AUTH_TOKEN_PER_USER=3)
+@pytest.mark.django_db
+def test_get_tokens_over_limit():
+    now = tz_now()
+    # Times are relative to now
+    # (key, created on in seconds , expiration in seconds)
+    test_data = [
+        # a is implicitly expired
+        ("a", -1000, -10),
+        # b's are invalid due to session limit of 3
+        ("b", -100, 60),
+        ("bb", -100, 60),
+        ("c", -90, 70),
+        ("d", -80, 80),
+        ("e", -70, 90),
+    ]
+    user = User.objects.create_superuser('admin', 'foo@bar.com', 'password')
+    for key, t_create, t_expire in test_data:
+        AuthToken.objects.create(
+            user=user,
+            key=key,
+            request_hash='this_is_a_hash',
+            created=now + timedelta(seconds=t_create),
+            expires=now + timedelta(seconds=t_expire),
+        )
+    invalid_tokens = AuthToken.get_tokens_over_limit(user, now=now)
+    invalid_keys = [x.key for x in invalid_tokens]
+    assert len(invalid_keys) == 2
+    assert 'b' in invalid_keys
+    assert 'bb' in invalid_keys