mirror of
https://github.com/ansible/awx.git
synced 2026-03-21 19:07:39 -02:30
Merge pull request #12251 from nixocio/ui_issue_11196
Add controller_node to job details page
This commit is contained in:
@@ -2236,7 +2236,6 @@ class InventoryUpdateSerializer(UnifiedJobSerializer, InventorySourceOptionsSeri
|
|||||||
'source_project_update',
|
'source_project_update',
|
||||||
'custom_virtualenv',
|
'custom_virtualenv',
|
||||||
'instance_group',
|
'instance_group',
|
||||||
'-controller_node',
|
|
||||||
)
|
)
|
||||||
|
|
||||||
def get_related(self, obj):
|
def get_related(self, obj):
|
||||||
@@ -2311,7 +2310,6 @@ class InventoryUpdateDetailSerializer(InventoryUpdateSerializer):
|
|||||||
class InventoryUpdateListSerializer(InventoryUpdateSerializer, UnifiedJobListSerializer):
|
class InventoryUpdateListSerializer(InventoryUpdateSerializer, UnifiedJobListSerializer):
|
||||||
class Meta:
|
class Meta:
|
||||||
model = InventoryUpdate
|
model = InventoryUpdate
|
||||||
fields = ('*', '-controller_node') # field removal undone by UJ serializer
|
|
||||||
|
|
||||||
|
|
||||||
class InventoryUpdateCancelSerializer(InventoryUpdateSerializer):
|
class InventoryUpdateCancelSerializer(InventoryUpdateSerializer):
|
||||||
|
|||||||
@@ -220,7 +220,7 @@ class TestControllerNode:
|
|||||||
assert 'controller_node' not in r.data
|
assert 'controller_node' not in r.data
|
||||||
|
|
||||||
r = get(reverse('api:inventory_update_detail', kwargs={'pk': inventory_update.pk}), admin_user, expect=200)
|
r = get(reverse('api:inventory_update_detail', kwargs={'pk': inventory_update.pk}), admin_user, expect=200)
|
||||||
assert 'controller_node' not in r.data
|
assert 'controller_node' in r.data
|
||||||
|
|
||||||
r = get(reverse('api:system_job_detail', kwargs={'pk': system_job.pk}), admin_user, expect=200)
|
r = get(reverse('api:system_job_detail', kwargs={'pk': system_job.pk}), admin_user, expect=200)
|
||||||
assert 'controller_node' not in r.data
|
assert 'controller_node' not in r.data
|
||||||
|
|||||||
@@ -186,7 +186,6 @@ function JobDetail({ job, inventorySourceLabels }) {
|
|||||||
}
|
}
|
||||||
return null;
|
return null;
|
||||||
};
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<CardBody>
|
<CardBody>
|
||||||
<DetailList>
|
<DetailList>
|
||||||
@@ -349,6 +348,13 @@ function JobDetail({ job, inventorySourceLabels }) {
|
|||||||
label={t`Execution Node`}
|
label={t`Execution Node`}
|
||||||
value={job.execution_node}
|
value={job.execution_node}
|
||||||
/>
|
/>
|
||||||
|
{job?.controller_node ? (
|
||||||
|
<Detail
|
||||||
|
dataCy="job-controller-node"
|
||||||
|
label={t`Controller Node`}
|
||||||
|
value={job.controller_node}
|
||||||
|
/>
|
||||||
|
) : null}
|
||||||
{instanceGroup && !instanceGroup?.is_container_group && (
|
{instanceGroup && !instanceGroup?.is_container_group && (
|
||||||
<Detail
|
<Detail
|
||||||
dataCy="job-instance-group"
|
dataCy="job-instance-group"
|
||||||
@@ -388,7 +394,6 @@ function JobDetail({ job, inventorySourceLabels }) {
|
|||||||
helpText={jobHelpText.forks}
|
helpText={jobHelpText.forks}
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{credential && (
|
{credential && (
|
||||||
<Detail
|
<Detail
|
||||||
dataCy="job-machine-credential"
|
dataCy="job-machine-credential"
|
||||||
|
|||||||
Reference in New Issue
Block a user