From d1f3acdd00cd5e579c99358299b61366355c3a3e Mon Sep 17 00:00:00 2001 From: Chris Meyers Date: Wed, 29 Apr 2015 12:32:58 -0400 Subject: [PATCH] replaced explicit objects.get() calls with get_object(). Handles errors much more gracefully. --- awx/api/views.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/awx/api/views.py b/awx/api/views.py index fadcd19b13..e52dd77009 100644 --- a/awx/api/views.py +++ b/awx/api/views.py @@ -619,7 +619,7 @@ class ProjectDetail(RetrieveUpdateDestroyAPIView): serializer_class = ProjectSerializer def destroy(self, request, *args, **kwargs): - obj = Project.objects.get(pk=kwargs['pk']) + obj = self.get_object() can_delete = request.user.can_access(Project, 'delete', obj) if not can_delete: raise PermissionDenied("Cannot delete project") @@ -1323,7 +1323,7 @@ class InventorySourceDetail(RetrieveUpdateAPIView): new_in_14 = True def destroy(self, request, *args, **kwargs): - obj = InventorySource.objects.get(pk=kwargs['pk']) + obj = self.get_object() can_delete = request.user.can_access(InventorySource, 'delete', obj) if not can_delete: raise PermissionDenied("Cannot delete inventory source") @@ -1425,7 +1425,7 @@ class JobTemplateDetail(RetrieveUpdateDestroyAPIView): serializer_class = JobTemplateSerializer def destroy(self, request, *args, **kwargs): - obj = JobTemplate.objects.get(pk=kwargs['pk']) + obj = self.get_object() can_delete = request.user.can_access(JobTemplate, 'delete', obj) if not can_delete: raise PermissionDenied("Cannot delete job template")