From 3e433dc9f35538a1273d78ac1dc2d2ec40075e5d Mon Sep 17 00:00:00 2001 From: AlanCoding Date: Mon, 11 Jul 2016 11:27:08 -0400 Subject: [PATCH] Remove old method of appending errors because it makes attrs None, causing server errors --- awx/api/serializers.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/awx/api/serializers.py b/awx/api/serializers.py index 9ce7aee670..f305370f64 100644 --- a/awx/api/serializers.py +++ b/awx/api/serializers.py @@ -1926,12 +1926,11 @@ class JobSerializer(UnifiedJobSerializer, JobOptionsSerializer): def to_internal_value(self, data): # When creating a new job and a job template is specified, populate any # fields not provided in data from the job template. - if not self.instance and isinstance(data, dict) and 'job_template' in data: + if not self.instance and isinstance(data, dict) and data.get('job_template', False): try: job_template = JobTemplate.objects.get(pk=data['job_template']) except JobTemplate.DoesNotExist: - self._errors = {'job_template': 'Invalid job template.'} - return + raise serializers.ValidationError({'job_template': 'Invalid job template.'}) data.setdefault('name', job_template.name) data.setdefault('description', job_template.description) data.setdefault('job_type', job_template.job_type) @@ -2694,8 +2693,7 @@ class TowerSettingsSerializer(BaseSerializer): def to_internal_value(self, data): if data['key'] not in settings.TOWER_SETTINGS_MANIFEST: - self._errors = {'key': 'Key {0} is not a valid settings key.'.format(data['key'])} - return + raise serializers.ValidationError({'key': ['Key {0} is not a valid settings key.'.format(data['key'])]}) ret = super(TowerSettingsSerializer, self).to_internal_value(data) manifest_val = settings.TOWER_SETTINGS_MANIFEST[data['key']] ret['description'] = manifest_val['description']