mirror of
https://github.com/ansible/awx.git
synced 2026-06-22 23:27:46 -02:30
fix access problems (#15)
* fix access problems and add Add bulk job max settings to api filter workflow job nodes better This will both improve performance by limiting the queryset for the node sublists as well as fix our access problem. override can_read instead of modify queryset in access.py We do this because we are not going to expose bulk jobs to the list views, which is complicatd and has poor performance implications. Instead, we just care about individual Workflows that clients get linked to not being broken. fix comment remove the get functions from the conf.py for bulk api max value comment the api expose of the bulk job variables reformt conf.py with make black trailing space add more assertion to the bulk host create test
This commit is contained in:
@@ -1999,10 +1999,14 @@ class WorkflowJobNodeAccess(BaseAccess):
|
||||
def filtered_queryset(self):
|
||||
return self.model.objects.filter(
|
||||
Q(workflow_job__unified_job_template__in=UnifiedJobTemplate.accessible_pk_qs(self.user, 'read_role'))
|
||||
| Q(workflow_job__created_by_id=self.user.id, workflow_job__is_bulk_job=True)
|
||||
| Q(workflow_job__organization__in=Organization.objects.filter(Q(admin_role__members=self.user)), workflow_job__is_bulk_job=True)
|
||||
)
|
||||
|
||||
def can_read(self, obj):
|
||||
if obj.workflow_job.is_bulk_job and obj.workflow_job.created_by_id == self.user.id:
|
||||
return True
|
||||
return super().can_read(obj)
|
||||
|
||||
@check_superuser
|
||||
def can_add(self, data):
|
||||
if data is None: # Hide direct creation in API browser
|
||||
@@ -2129,10 +2133,14 @@ class WorkflowJobAccess(BaseAccess):
|
||||
def filtered_queryset(self):
|
||||
return WorkflowJob.objects.filter(
|
||||
Q(unified_job_template__in=UnifiedJobTemplate.accessible_pk_qs(self.user, 'read_role'))
|
||||
| Q(created_by_id=self.user.id, is_bulk_job=True)
|
||||
| Q(organization__in=Organization.objects.filter(Q(admin_role__members=self.user)), is_bulk_job=True)
|
||||
)
|
||||
|
||||
def can_read(self, obj):
|
||||
if obj.is_bulk_job and obj.created_by_id == self.user.id:
|
||||
return True
|
||||
return super().can_read(obj)
|
||||
|
||||
def can_add(self, data):
|
||||
# Old add-start system for launching jobs is being depreciated, and
|
||||
# not supported for new types of resources
|
||||
|
||||
Reference in New Issue
Block a user