AC-198 All username/password fields and all forms now have autocomplete='false' attribute to prevent browser autofill. Fixed Firefox password save prompt issue. Prompt was ~ 'Do you want to save password for <organization name>'. The prompt is now '...password for <username>'. The issue is the order of the fields. Prompt is build off of first field appearing before password field. Moved organization up and put username before password. Created an Angular approach to removing pre-selected class (the green success class) from a previously used list. Now lists won't appear to have pre-selected. This was kind of wokring with a jQuery approach now it's solid. New method applied to Users only. Will push to other modals shortly.

awx/ui/static/js/forms/Users.js

@@ -20,12 +20,6 @@ angular.module('UserFormDefinition', [])
         collapseOpen: true,
 
         fields: {
-            username: {
-                label: 'Username',
-                type: 'text',
-                addRequired: true,
-                editRequired: true
-                },
             first_name: { 
                 label: 'First Name',
                 type: 'text',
@@ -44,7 +38,8 @@ angular.module('UserFormDefinition', [])
                 label: 'Email',
                 type: 'email',
                 addRequired: true,
-                editRequired: true
+                editRequired: true,
+                autocomplete: false
                 },
             organization: {
                 label: 'Organization',
@@ -56,12 +51,20 @@ angular.module('UserFormDefinition', [])
                 ngClick: 'lookUpOrganization()',
                 excludeMode: 'edit'
                 },
+            username: {
+                label: 'Username',
+                type: 'text',
+                addRequired: true,
+                editRequired: true,
+                autocomplete: false
+                },
             password: {
                 label: 'Password',
                 type: 'password',
                 addRequired: true,
                 editRequired: false,
-                ngChange: "clearPWConfirm('password_confirm')"
+                ngChange: "clearPWConfirm('password_confirm')",
+                autocomplete: false
                 },
             password_confirm: {
                 label: 'Confirm Password',
@@ -69,7 +72,8 @@ angular.module('UserFormDefinition', [])
                 addRequired: false,
                 editRequired: false,
                 awPassMatch: true,
-                associated: 'password'
+                associated: 'password',
+                autocomplete: false
                 },
             is_superuser: {
                 label: 'Superuser?',