Merge pull request #4678 from beeankha/delete_cloudforms_from_collections

Remove Cloudforms as a credential type from collections

awx_collection/plugins/modules/tower_credential.py

@@ -74,7 +74,7 @@ options:
         - Deprecated, please use credential_type
       required: False
       type: str
-      choices: ["ssh", "vault", "net", "scm", "aws", "vmware", "satellite6", "cloudforms", "gce", "azure_rm", "openstack", "rhv", "insights", "tower"]
+      choices: ["ssh", "vault", "net", "scm", "aws", "vmware", "satellite6", "gce", "azure_rm", "openstack", "rhv", "insights", "tower"]
     host:
       description:
         - Host for this credential.
@@ -285,7 +285,6 @@ KIND_CHOICES = {
     'aws': 'Amazon Web Services',
     'vmware': 'VMware vCenter',
     'satellite6': 'Red Hat Satellite 6',
-    'cloudforms': 'Red Hat CloudForms',
     'gce': 'Google Compute Engine',
     'azure_rm': 'Microsoft Azure Resource Manager',
     'openstack': 'OpenStack',

awx_collection/test/awx/test_inventory_source.py

@@ -182,18 +182,18 @@ def test_falsy_value(run_module, admin_user, base_inventory):
 # We want to let the API return issues with "this doesn't support that", etc.
 #
 # GUI OPTIONS:
-# - - - - - - - manual:	file:	scm:	ec2:	gce	azure_rm	vmware	sat	cloudforms	openstack	rhv	tower	custom
+# - - - - - - - manual:	file:	scm:	ec2:	gce	azure_rm	vmware	sat	openstack	rhv	tower	custom
-# credential		?	?	o	o	r	r		r	r	r		r		r	r	o
+# credential		?	?	o	o	r	r		r	r		r		r	r	o
-# source_project	?	?	r	-	-	-		-	-	-		-		-	-	-
+# source_project	?	?	r	-	-	-		-	-		-		-	-	-
-# source_path		?	?	r	-	-	-		-	-	-		-		-	-	-
+# source_path		?	?	r	-	-	-		-	-		-		-	-	-
-# verbosity			?	?	o	o	o	o		o	o	o		o		o	o	o
+# verbosity			?	?	o	o	o	o		o	o		o		o	o	o
-# overwrite			?	?	o	o	o	o		o	o	o		o		o	o	o
+# overwrite			?	?	o	o	o	o		o	o		o		o	o	o
-# overwrite_vars	?	?	o	o	o	o		o	o	o		o		o	o	o
+# overwrite_vars	?	?	o	o	o	o		o	o		o		o	o	o
-# update_on_launch	?	?	o	o	o	o		o	o	o		o		o	o	o
+# update_on_launch	?	?	o	o	o	o		o	o		o		o	o	o
-# UoPL          	?	?	o	-	-	-		-	-	-		-		-	-	-
+# UoPL          	?	?	o	-	-	-		-	-		-		-	-	-
-# source_vars*		?	?	-	o	-	o		o	o	o		o		-	-	-
+# source_vars*		?	?	-	o	-	o		o	o		o		-	-	-
-# environmet vars*	?	?	o	-	-	-		-	-	-		-		-	-	o
+# environmet vars*	?	?	o	-	-	-		-	-		-		-	-	o
-# source_script		?	?	-	-	-	-		-	-	-		-		-	-	r
+# source_script		?	?	-	-	-	-		-	-		-		-	-	r
 #
 # UoPL - update_on_project_launch
 # * - source_vars are labeled environment_vars on project and custom sources

awx_collection/tests/integration/targets/tower_credential/tasks/main.yml

@@ -17,7 +17,6 @@
     aws_cred_name1: "AWX-Collection-tests-tower_credential-aws-cred1-{{ test_id }}"
     vmware_cred_name1: "AWX-Collection-tests-tower_credential-vmware-cred1-{{ test_id }}"
     sat6_cred_name1: "AWX-Collection-tests-tower_credential-sat6-cred1-{{ test_id }}"
-    cf_cred_name1: "AWX-Collection-tests-tower_credential-cf-cred1-{{ test_id }}"
     gce_cred_name1: "AWX-Collection-tests-tower_credential-gce-cred1-{{ test_id }}"
     azurerm_cred_name1: "AWX-Collection-tests-tower_credential-azurerm-cred1-{{ test_id }}"
     openstack_cred_name1: "AWX-Collection-tests-tower_credential-openstack-cred1-{{ test_id }}"
@@ -534,33 +533,6 @@
     that:
       - "result is changed"
 
-- name: Create a valid CloudForms credential
-  tower_credential:
-    name: "{{ cf_cred_name1 }}"
-    organization: Default
-    state: present
-    kind: cloudforms
-    host: https://example.org
-    username: joe
-    password: secret
-  register: result
-
-- assert:
-    that:
-      - "result is changed"
-
-- name: Delete a CloudForms credential
-  tower_credential:
-    name: "{{ cf_cred_name1 }}"
-    organization: Default
-    state: absent
-    kind: cloudforms
-  register: result
-
-- assert:
-    that:
-      - "result is changed"
-
 - name: Create a valid GCE credential
   tower_credential:
     name: "{{ gce_cred_name1 }}"