From 091c56703536fb6433a8e56476bdfd37ba352ade Mon Sep 17 00:00:00 2001 From: Ken Hoes Date: Fri, 27 May 2016 12:13:16 -0400 Subject: [PATCH 1/2] Fixed list message boxes for super and non-super user edits --- awx/ui/client/src/forms/Users.js | 2 -- awx/ui/client/src/shared/form-generator.js | 8 +++++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/awx/ui/client/src/forms/Users.js b/awx/ui/client/src/forms/Users.js index febc6b8ddb..f1e6aada99 100644 --- a/awx/ui/client/src/forms/Users.js +++ b/awx/ui/client/src/forms/Users.js @@ -138,8 +138,6 @@ export default iterator: 'team', open: false, index: false, - suppressEmptyText: true, - actions: {}, fields: { diff --git a/awx/ui/client/src/shared/form-generator.js b/awx/ui/client/src/shared/form-generator.js index c75bfd7afb..4466229ab8 100644 --- a/awx/ui/client/src/shared/form-generator.js +++ b/awx/ui/client/src/shared/form-generator.js @@ -1839,10 +1839,12 @@ angular.module('FormGenerator', [GeneratorHelpers.name, 'Utilities', listGenerat // Show the "no items" box when loading is done and the user isn't actively searching and there are no results // Allow for the suppression of the empty list text to avoid duplication between form generator and list generator - if(!collection.suppressEmptyText || collection.suppressEmptyText === false) { + //if(collection.hideOnSuperuser && collection.hideOnSuperuser !== true) { var emptyListText = (collection.emptyListText) ? collection.emptyListText : "PLEASE ADD ITEMS TO THIS LIST"; - html += "
" + emptyListText + "
"; - } + html += '
'; + html += "
" + emptyListText + "
"; + html += '
'; + //} html += `
From a16cb2cd69e223b712631e95bf7b4462e84d80bb Mon Sep 17 00:00:00 2001 From: Ken Hoes Date: Wed, 1 Jun 2016 08:40:34 -0400 Subject: [PATCH 2/2] PR Feedback --- awx/ui/client/src/shared/form-generator.js | 1 - 1 file changed, 1 deletion(-) diff --git a/awx/ui/client/src/shared/form-generator.js b/awx/ui/client/src/shared/form-generator.js index 4466229ab8..1eb0be8487 100644 --- a/awx/ui/client/src/shared/form-generator.js +++ b/awx/ui/client/src/shared/form-generator.js @@ -1839,7 +1839,6 @@ angular.module('FormGenerator', [GeneratorHelpers.name, 'Utilities', listGenerat // Show the "no items" box when loading is done and the user isn't actively searching and there are no results // Allow for the suppression of the empty list text to avoid duplication between form generator and list generator - //if(collection.hideOnSuperuser && collection.hideOnSuperuser !== true) { var emptyListText = (collection.emptyListText) ? collection.emptyListText : "PLEASE ADD ITEMS TO THIS LIST"; html += '
'; html += "
" + emptyListText + "
";