Merge pull request #5086 from keithjgrant/4614-fix-template-edit-border

Fix border/padding while loading jt edit form

Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
This commit is contained in:
softwarefactory-project-zuul[bot]
2019-10-25 16:31:53 +00:00
committed by GitHub
2 changed files with 12 additions and 13 deletions

View File

@@ -179,11 +179,19 @@ class JobTemplateEdit extends Component {
const canEdit = template.summary_fields.user_capabilities.edit; const canEdit = template.summary_fields.user_capabilities.edit;
if (hasContentLoading) { if (hasContentLoading) {
return <ContentLoading />; return (
<CardBody>
<ContentLoading />
</CardBody>
);
} }
if (contentError) { if (contentError) {
return <ContentError error={contentError} />; return (
<CardBody>
<ContentError error={contentError} />
</CardBody>
);
} }
if (!canEdit) { if (!canEdit) {

View File

@@ -7,7 +7,6 @@ import { withFormik, Field } from 'formik';
import { import {
Form, Form,
FormGroup, FormGroup,
Card,
Switch, Switch,
Checkbox, Checkbox,
TextInput, TextInput,
@@ -165,19 +164,11 @@ class JobTemplateForm extends Component {
} }
if (hasContentLoading) { if (hasContentLoading) {
return ( return <ContentLoading />;
<Card className="awx-c-card">
<ContentLoading />
</Card>
);
} }
if (contentError) { if (contentError) {
return ( return <ContentError error={contentError} />;
<Card className="awx-c-card">
<ContentError error={contentError} />
</Card>
);
} }
const AdvancedFieldsWrapper = template.isNew ? CollapsibleSection : 'div'; const AdvancedFieldsWrapper = template.isNew ? CollapsibleSection : 'div';
return ( return (