External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-15 05:17:36 -02:30
Code Issues Packages Projects Releases Wiki Activity

schedule capability set to False for manual groups

Browse Source
This commit is contained in:
AlanCoding
2016-10-10 10:49:58 -04:00
parent 34b638f59d
commit 48c155dfb0
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
awx/main/access.py
View File

@@ -305,13 +305,13 @@ class BaseAccess(object):
if display_method not in method_list: if display_method not in method_list:
continue continue
# Validation consistency checks # Actions not possible for reason unrelated to RBAC: validation, etc.
if display_method == 'copy' and isinstance(obj, JobTemplate): if display_method == 'copy' and isinstance(obj, JobTemplate):
validation_errors, resources_needed_to_start = obj.resource_validation_data() validation_errors, resources_needed_to_start = obj.resource_validation_data()
if validation_errors: if validation_errors:
user_capabilities[display_method] = False user_capabilities[display_method] = False
continue continue
elif display_method == 'start' and isinstance(obj, Group): elif display_method in ['start', 'schedule'] and isinstance(obj, Group):
if obj.inventory_source and not obj.inventory_source._can_update(): if obj.inventory_source and not obj.inventory_source._can_update():
user_capabilities[display_method] = False user_capabilities[display_method] = False
continue continue

4
awx/main/tests/functional/api/test_rbac_displays.py
View File

@@ -333,13 +333,15 @@ def test_group_update_capabilities_possible(group, inventory_source, admin_user)
@pytest.mark.django_db @pytest.mark.django_db
def test_group_update_capabilities_impossible(group, inventory_source, admin_user): def test_group_update_capabilities_impossible(group, inventory_source, admin_user):
"Manual groups can not be updated or scheduled"
inventory_source.source = "" inventory_source.source = ""
inventory_source.save() inventory_source.save()
group.inventory_source = inventory_source group.inventory_source = inventory_source
group.save() group.save()
capabilities = get_user_capabilities(admin_user, group, method_list=['start']) capabilities = get_user_capabilities(admin_user, group, method_list=['edit', 'start', 'schedule'])
assert not capabilities['start'] assert not capabilities['start']
assert not capabilities['schedule']
@pytest.mark.django_db @pytest.mark.django_db