changes from PR feedback: removing ghost action icon

and fixing a bug where the list of job templates was improperly
updated when a job was running and live events were received.
This commit is contained in:
Jared Tabor
2017-10-26 16:50:12 -07:00
parent 5e349590fd
commit 4fbfddaa93
2 changed files with 24 additions and 21 deletions

View File

@@ -33,6 +33,7 @@ export default {
ListDefinition: ['TemplateList', '$transition$', (TemplateList, $transition$) => { ListDefinition: ['TemplateList', '$transition$', (TemplateList, $transition$) => {
let id = $transition$.params().project_id; let id = $transition$.params().project_id;
TemplateList.actions.add.ngClick = `$state.go('templates.addJobTemplate', {project_id: ${id}})`; TemplateList.actions.add.ngClick = `$state.go('templates.addJobTemplate', {project_id: ${id}})`;
TemplateList.basePath = 'job_templates';
return TemplateList; return TemplateList;
}], }],
Dataset: ['ListDefinition', 'QuerySet', '$stateParams', 'GetBasePath', '$interpolate', '$rootScope', Dataset: ['ListDefinition', 'QuerySet', '$stateParams', 'GetBasePath', '$interpolate', '$rootScope',

View File

@@ -1950,6 +1950,7 @@ angular.module('FormGenerator', [GeneratorHelpers.name, 'Utilities', listGenerat
if (collection.fieldActions) { if (collection.fieldActions) {
html += "<td class=\"List-actionsContainer\"><div class=\"List-tableCell List-actionButtonCell actions\">"; html += "<td class=\"List-actionsContainer\"><div class=\"List-tableCell List-actionButtonCell actions\">";
for (act in collection.fieldActions) { for (act in collection.fieldActions) {
if (act !== 'columnClass') {
fAction = collection.fieldActions[act]; fAction = collection.fieldActions[act];
html += "<button id=\"" + ((fAction.id) ? fAction.id : act + "-action") + "\" "; html += "<button id=\"" + ((fAction.id) ? fAction.id : act + "-action") + "\" ";
html += (fAction.awToolTip) ? 'aw-tool-tip="' + fAction.awToolTip + '"' : ''; html += (fAction.awToolTip) ? 'aw-tool-tip="' + fAction.awToolTip + '"' : '';
@@ -1974,6 +1975,7 @@ angular.module('FormGenerator', [GeneratorHelpers.name, 'Utilities', listGenerat
//html += (fAction.label) ? "<span class=\"list-action-label\"> " + fAction.label + "</span>": ""; //html += (fAction.label) ? "<span class=\"list-action-label\"> " + fAction.label + "</span>": "";
html += "</button>"; html += "</button>";
} }
}
html += "</div></td>"; html += "</div></td>";
html += "</tr>\n"; html += "</tr>\n";
} }