External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-20 07:17:40 -02:30
Code Issues Packages Projects Releases Wiki Activity

Add protection against credential getattr

Browse Source 
Relates #474.

Add protection in `__getattr__` method to prevent possible infinite
recursion loop.

Signed-off-by: Aaron Tan <jangsutsr@gmail.com>
This commit is contained in:
Aaron Tan
2017-10-24 12:08:41 -04:00
parent 73ece87e68
commit 553e81f888
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
awx/main/models/credential.py
View File

@@ -249,10 +249,11 @@ class Credential(PasswordFieldsModel, CommonModelNameNotUnique, ResourceMixin):
]) ])
def __getattr__(self, item): def __getattr__(self, item):
if item in V1Credential.FIELDS: if item != 'inputs':
return self.inputs.get(item, V1Credential.FIELDS[item].default) if item in V1Credential.FIELDS:
elif item in self.inputs: return self.inputs.get(item, V1Credential.FIELDS[item].default)
return self.inputs[item] elif item in self.inputs:
return self.inputs[item]
raise AttributeError(item) raise AttributeError(item)
def __setattr__(self, item, value): def __setattr__(self, item, value):