From 58bad6cfa93f975e2d72e6d43801d7f3071b0164 Mon Sep 17 00:00:00 2001 From: Kia Lam Date: Wed, 21 Dec 2022 10:44:12 -0800 Subject: [PATCH] Conditionally query /health_check endpoint for execution node only. --- .../InstanceDetails/InstanceDetails.js | 37 ++++++++----------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/awx/ui/src/screens/InstanceGroup/InstanceDetails/InstanceDetails.js b/awx/ui/src/screens/InstanceGroup/InstanceDetails/InstanceDetails.js index b4ab4dc81f..e0dd8a09fa 100644 --- a/awx/ui/src/screens/InstanceGroup/InstanceDetails/InstanceDetails.js +++ b/awx/ui/src/screens/InstanceGroup/InstanceDetails/InstanceDetails.js @@ -81,35 +81,30 @@ function InstanceDetails({ setBreadcrumb, instanceGroup }) { const { data: { results }, } = await InstanceGroupsAPI.readInstances(instanceGroup.id); - let instanceDetails; const isAssociated = results.some( ({ id: instId }) => instId === parseInt(instanceId, 10) ); if (isAssociated) { - const [{ data: details }, { data: healthCheckData }] = - await Promise.all([ - InstancesAPI.readDetail(instanceId), - InstancesAPI.readHealthCheckDetail(instanceId), - ]); - - instanceDetails = details; - setHealthCheck(healthCheckData); - } else { - throw new Error( - `This instance is not associated with this instance group` + const { data: details } = await InstancesAPI.readDetail(instanceId); + if (details.node_type === 'execution') { + const { data: healthCheckData } = + await InstancesAPI.readHealthCheckDetail(instanceId); + setHealthCheck(healthCheckData); + } + setBreadcrumb(instanceGroup, details); + setForks( + computeForks( + details.mem_capacity, + details.cpu_capacity, + details.capacity_adjustment + ) ); + return { instance: details }; } - - setBreadcrumb(instanceGroup, instanceDetails); - setForks( - computeForks( - instanceDetails.mem_capacity, - instanceDetails.cpu_capacity, - instanceDetails.capacity_adjustment - ) + throw new Error( + `This instance is not associated with this instance group` ); - return { instance: instanceDetails }; }, [instanceId, setBreadcrumb, instanceGroup]), { instance: {}, isLoading: true } );