From 5c91f663168c69c2fc9740c874b8e840abe35b2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ely=C3=A9zer=20Rezende?= Date: Wed, 29 Apr 2020 13:55:35 -0400 Subject: [PATCH] Keep awxkit's requirements on the setup.py awxkit's setup.py was making use of pip internal structures to parse the requirements.txt file. This is not a good thing as they may change, actually that just happened. To avoid this in the future, move the list of requirements to setup.py and make requirements.txt list `.` as the only item. This way we keep a single place to update requirements in the future and avoid accessing pip's internals. --- awxkit/requirements.txt | 3 +-- awxkit/setup.py | 11 ++++------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/awxkit/requirements.txt b/awxkit/requirements.txt index 6c9fdba970..9c558e357c 100644 --- a/awxkit/requirements.txt +++ b/awxkit/requirements.txt @@ -1,2 +1 @@ -PyYAML -requests +. diff --git a/awxkit/setup.py b/awxkit/setup.py index 2f304f2600..7dac7a7b8e 100644 --- a/awxkit/setup.py +++ b/awxkit/setup.py @@ -2,12 +2,6 @@ import os import glob import shutil from setuptools import setup, find_packages, Command -try: # for pip >= 10 - from pip._internal.req import parse_requirements -except ImportError: # for pip <= 9.0.3 - from pip.req import parse_requirements - -requirements = [str(r.req) for r in parse_requirements('requirements.txt', session=False)] def get_version(): @@ -66,7 +60,10 @@ setup( 'clean': CleanCommand, }, include_package_data=True, - install_requires=requirements, + install_requires=[ + 'PyYAML', + 'requests', + ], python_requires=">=3.6", extras_require={ 'formatting': ['jq'],