From 5ca0cdb124fb02d43461a674b075453693c42d7c Mon Sep 17 00:00:00 2001 From: Shane McDonald Date: Fri, 10 May 2019 12:19:39 -0400 Subject: [PATCH] Avoid DNS timeout in non-Docker for Mac installs Shaves 20 seconds off of rebooting the dev environment on Linux. --- Makefile | 4 ++-- awx/settings/development.py | 6 +++--- tools/docker-compose.yml | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index faa5fd4613..b460aa5116 100644 --- a/Makefile +++ b/Makefile @@ -554,7 +554,7 @@ docker-isolated: # Docker Compose Development environment docker-compose: docker-auth - CURRENT_UID=$(shell id -u) TAG=$(COMPOSE_TAG) DEV_DOCKER_TAG_BASE=$(DEV_DOCKER_TAG_BASE) docker-compose -f tools/docker-compose.yml up --no-recreate awx + CURRENT_UID=$(shell id -u) OS="$(shell docker info | grep 'Operating System')" TAG=$(COMPOSE_TAG) DEV_DOCKER_TAG_BASE=$(DEV_DOCKER_TAG_BASE) docker-compose -f tools/docker-compose.yml up --no-recreate awx docker-compose-cluster: docker-auth CURRENT_UID=$(shell id -u) TAG=$(COMPOSE_TAG) DEV_DOCKER_TAG_BASE=$(DEV_DOCKER_TAG_BASE) docker-compose -f tools/docker-compose-cluster.yml up @@ -564,7 +564,7 @@ docker-compose-credential-plugins: docker-auth CURRENT_UID=$(shell id -u) TAG=$(COMPOSE_TAG) DEV_DOCKER_TAG_BASE=$(DEV_DOCKER_TAG_BASE) docker-compose -f tools/docker-compose.yml -f tools/docker-credential-plugins-override.yml up --no-recreate awx docker-compose-test: docker-auth - cd tools && CURRENT_UID=$(shell id -u) TAG=$(COMPOSE_TAG) DEV_DOCKER_TAG_BASE=$(DEV_DOCKER_TAG_BASE) docker-compose run --rm --service-ports awx /bin/bash + cd tools && CURRENT_UID=$(shell id -u) OS="$(shell docker info | grep 'Operating System')" TAG=$(COMPOSE_TAG) DEV_DOCKER_TAG_BASE=$(DEV_DOCKER_TAG_BASE) docker-compose run --rm --service-ports awx /bin/bash docker-compose-runtest: cd tools && CURRENT_UID=$(shell id -u) TAG=$(COMPOSE_TAG) DEV_DOCKER_TAG_BASE=$(DEV_DOCKER_TAG_BASE) docker-compose run --rm --service-ports awx /start_tests.sh diff --git a/awx/settings/development.py b/awx/settings/development.py index 0de8314f28..e839846c7e 100644 --- a/awx/settings/development.py +++ b/awx/settings/development.py @@ -155,10 +155,10 @@ CELERYBEAT_SCHEDULE.update({ # noqa CLUSTER_HOST_ID = socket.gethostname() -try: - socket.gethostbyname('docker.for.mac.host.internal') + +if 'Docker for Mac' in os.getenv('OS', ''): os.environ['SDB_NOTIFY_HOST'] = 'docker.for.mac.host.internal' -except Exception: +else: os.environ['SDB_NOTIFY_HOST'] = os.popen('ip route').read().split(' ')[2] WEBSOCKET_ORIGIN_WHITELIST = ['https://localhost:8043', 'https://localhost:3000'] diff --git a/tools/docker-compose.yml b/tools/docker-compose.yml index 790089a6f5..7710b00548 100644 --- a/tools/docker-compose.yml +++ b/tools/docker-compose.yml @@ -9,6 +9,7 @@ services: command: /start_development.sh environment: CURRENT_UID: + OS: RABBITMQ_HOST: rabbitmq RABBITMQ_USER: guest RABBITMQ_PASS: guest