Clean up RBAC code

This commit is contained in:
beeankha
2019-08-01 16:57:44 -04:00
committed by Ryan Petrello
parent 296b4e830b
commit 5f82754a3f
4 changed files with 2 additions and 16 deletions

View File

@@ -3455,9 +3455,7 @@ class WorkflowApprovalTemplateSerializer(UnifiedJobTemplateSerializer):
if 'last_job' in res:
del res['last_job']
res.update(dict(
jobs = self.reverse('api:workflow_approval_template_jobs_list', kwargs={'pk': obj.pk}),
))
res.update(dict(jobs = self.reverse('api:workflow_approval_template_jobs_list', kwargs={'pk': obj.pk}),))
return res

View File

@@ -4453,7 +4453,6 @@ class WorkflowApprovalApprove(RetrieveAPIView):
model = models.WorkflowApproval
serializer_class = serializers.WorkflowApprovalViewSerializer
# &&&&&& Changed per the PR review, notes/questions in additional comments...
def post(self, request, *args, **kwargs):
obj = self.get_object()
request.user.can_access(models.WorkflowApproval, 'approve_or_deny', obj)
@@ -4467,7 +4466,6 @@ class WorkflowApprovalDeny(RetrieveAPIView):
model = models.WorkflowApproval
serializer_class = serializers.WorkflowApprovalViewSerializer
# &&&&&& Changed per the PR review, notes/questions in additional comments...
def post(self, request, *args, **kwargs):
obj = self.get_object()
request.user.can_access(models.WorkflowApproval, 'approve_or_deny', obj)