From 40700d76c90e3e9c63c62a1d3756aeb351bc701d Mon Sep 17 00:00:00 2001 From: Jared Tabor Date: Wed, 19 Aug 2015 15:37:36 -0700 Subject: [PATCH 1/2] change ng-show to ng-if and only make a job a cleanup job or fact cleanup job if extra vars have addtional properties --- .../lib/angular-scheduler/lib/angular-scheduler.html | 2 +- awx/ui/client/src/helpers/Schedules.js | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.html b/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.html index a13551c8a4..d20f5d6d82 100644 --- a/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.html +++ b/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.html @@ -25,7 +25,7 @@
Note: For facts collected older than the time period specified, save one fact scan (snapshot) per time window (frequency). For example, facts older than 30 days are purged, while one weekly fact scan is kept. Caution: Setting both numerical variables to "0" will delete all facts.
-
+
A value is required.
diff --git a/awx/ui/client/src/helpers/Schedules.js b/awx/ui/client/src/helpers/Schedules.js index 6c07823926..05aba42be6 100644 --- a/awx/ui/client/src/helpers/Schedules.js +++ b/awx/ui/client/src/helpers/Schedules.js @@ -220,13 +220,13 @@ export default Rest.get() .success(function(data) { schedule = data; - if(schedule.hasOwnProperty('extra_data')) { - if(schedule.extra_data.hasOwnProperty('granularity')){ - scope.isFactCleanup = true; - } else { - scope.cleanupJob = true; - } + if(schedule.extra_data.hasOwnProperty('granularity')){ + scope.isFactCleanup = true; } + if (schedule.extra_data.hasOwnProperty('days')){ + scope.cleanupJob = true; + } + scope.$emit('ScheduleFound'); }) .error(function(data,status){ From 8a583a820268ee647b7f1df5055e91071d63d0fd Mon Sep 17 00:00:00 2001 From: Jared Tabor Date: Tue, 25 Aug 2015 22:30:47 -0700 Subject: [PATCH 2/2] Changing the description in scheduler for minutely and hourly frequency --- awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.js b/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.js index 3a3b77d8f3..a45cfcab31 100644 --- a/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.js +++ b/awx/ui/client/lib/angular-scheduler/lib/angular-scheduler.js @@ -297,7 +297,10 @@ angular.module('AngularScheduler', ['underscore']) } return false; }); - scope.rrule_nlp_description = rrule.toText().replace(/^RRule error.*$/,'Natural language description not available'); + scope.rrule_nlp_description = rrule.toText().replace(/^RRule error.*$/,'Minutely or hourly frequency selected'); + if(rrule === "none"){ + scope.rrule_nlp_description = 'Natural language description not available'; + } scope.rrule = rrule.toString(); } };