External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-17 22:37:41 -02:30
Code Issues Packages Projects Releases Wiki Activity

Integrate unnecessary queries for better performance.

Browse Source
This commit is contained in:
Aaron Tan
2016-10-28 15:03:17 -04:00
parent 6ecd45681a
commit 62e0291f86
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
awx/api/views.py
View File

@@ -1090,9 +1090,8 @@ class ProjectUpdateDetail(RetrieveDestroyAPIView):
def destroy(self, request, *args, **kwargs): def destroy(self, request, *args, **kwargs):
obj = self.get_object() obj = self.get_object()
for unified_job_node in obj.unified_job_nodes.all(): if obj.unified_job_nodes.filter(workflow_job__status__in=ACTIVE_STATES).exists():
if unified_job_node.workflow_job.status in ACTIVE_STATES: raise PermissionDenied(detail='Can not delete job resource when associated workflow job is running.')
raise PermissionDenied(detail='Can not delete job resource when associated workflow job is running.')
return super(ProjectUpdateDetail, self).destroy(request, *args, **kwargs) return super(ProjectUpdateDetail, self).destroy(request, *args, **kwargs)
class ProjectUpdateCancel(RetrieveAPIView): class ProjectUpdateCancel(RetrieveAPIView):
@@ -2176,9 +2175,8 @@ class InventoryUpdateDetail(RetrieveDestroyAPIView):
def destroy(self, request, *args, **kwargs): def destroy(self, request, *args, **kwargs):
obj = self.get_object() obj = self.get_object()
for unified_job_node in obj.unified_job_nodes.all(): if obj.unified_job_nodes.filter(workflow_job__status__in=ACTIVE_STATES).exists():
if unified_job_node.workflow_job.status in ACTIVE_STATES: raise PermissionDenied(detail='Can not delete job resource when associated workflow job is running.')
raise PermissionDenied(detail='Can not delete job resource when associated workflow job is running.')
return super(InventoryUpdateDetail, self).destroy(request, *args, **kwargs) return super(InventoryUpdateDetail, self).destroy(request, *args, **kwargs)
class InventoryUpdateCancel(RetrieveAPIView): class InventoryUpdateCancel(RetrieveAPIView):
@@ -2886,9 +2884,8 @@ class JobDetail(RetrieveUpdateDestroyAPIView):
def destroy(self, request, *args, **kwargs): def destroy(self, request, *args, **kwargs):
obj = self.get_object() obj = self.get_object()
for unified_job_node in obj.unified_job_nodes.all(): if obj.unified_job_nodes.filter(workflow_job__status__in=ACTIVE_STATES).exists():
if unified_job_node.workflow_job.status in ACTIVE_STATES: raise PermissionDenied(detail='Can not delete job resource when associated workflow job is running.')
raise PermissionDenied(detail='Can not delete job resource when associated workflow job is running.')
return super(JobDetail, self).destroy(request, *args, **kwargs) return super(JobDetail, self).destroy(request, *args, **kwargs)
class JobLabelList(SubListAPIView): class JobLabelList(SubListAPIView):