External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-03-10 22:19:28 -02:30
Code Issues Packages Projects Releases Wiki Activity

Delete falsey project creds before POST|PATCH

Browse Source 
Depending on the permissions of the user submitting the form, the API
might throw an unexpected error if our creation request has a
zero-length string as its credential field. As a work-around,
normalize falsey credential fields by deleting them.
This commit is contained in:
Jake McDermott
2020-02-26 13:40:26 -05:00
parent bd30951a4f
commit 6536f5a453
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
awx/ui_next/src/screens/Project/ProjectAdd/ProjectAdd.jsx
View File

@@ -13,6 +13,13 @@ function ProjectAdd() {
if (values.scm_type === 'manual') { if (values.scm_type === 'manual') {
values.scm_type = ''; values.scm_type = '';
} }
if (!values.credential) {
// Depending on the permissions of the user submitting the form,
// the API might throw an unexpected error if our creation request
// has a zero-length string as its credential field. As a work-around,
// normalize falsey credential fields by deleting them.
delete values.credential;
}
setFormSubmitError(null); setFormSubmitError(null);
try { try {
const { const {

7
awx/ui_next/src/screens/Project/ProjectEdit/ProjectEdit.jsx
View File

@@ -13,6 +13,13 @@ function ProjectEdit({ project }) {
if (values.scm_type === 'manual') { if (values.scm_type === 'manual') {
values.scm_type = ''; values.scm_type = '';
} }
if (!values.credential) {
// Depending on the permissions of the user submitting the form,
// the API might throw an unexpected error if our creation request
// has a zero-length string as its credential field. As a work-around,
// normalize falsey credential fields by deleting them.
delete values.credential;
}
try { try {
const { const {
data: { id }, data: { id },