External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-13 04:17:36 -02:30
Code Issues Packages Projects Releases Wiki Activity

add job_description to failed workflow node

Browse Source 
* When workflow job fails because a workflow job node doesn't have a
related unified_job_template note that with an error on the workflow
job's job_description
* When a workflow job fails because a failure path isn't defined, note
that on the workflow job job_description
This commit is contained in:
chris meyers
2018-11-16 14:45:12 -05:00
committed by mabashian
parent 00d71cea50
commit 676c068b71
4 changed files with 21 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
awx/main/tests/unit/scheduler/test_dag_workflow.py
View File

@@ -27,7 +27,7 @@ def wf_node_generator(mocker):
@pytest.fixture
def workflow_dag_1(wf_node_generator):
g = WorkflowDAG()
nodes = [wf_node_generator() for i in range(4)]
nodes = [wf_node_generator(unified_job_template=object()) for i in range(4)]
map(lambda n: g.add_node(n), nodes)
r'''
@@ -183,17 +183,17 @@ class TestIsWorkflowDone():
assert g.is_workflow_done() is False
def test_is_workflow_done_failed(self, workflow_dag_failed):
g = workflow_dag_failed[0]
(g, nodes) = workflow_dag_failed
assert g.is_workflow_done() is True
assert g.has_workflow_failed() is True
assert g.has_workflow_failed() == (True, "Workflow job node {} has a status of 'failed' without an error handler path".format(nodes[2].id))
class TestHasWorkflowFailed():
@pytest.fixture
def workflow_dag_canceled(self, wf_node_generator):
g = WorkflowDAG()
nodes = [wf_node_generator() for i in range(1)]
nodes = [wf_node_generator(unified_job_template=object()) for i in range(1)]
map(lambda n: g.add_node(n), nodes)
r'''
F0
@@ -210,12 +210,12 @@ class TestHasWorkflowFailed():
def test_canceled_should_fail(self, workflow_dag_canceled):
(g, nodes) = workflow_dag_canceled
assert g.has_workflow_failed() is True
assert g.has_workflow_failed() == (True, "Workflow job node {} has a status of 'canceled' without an error handler path".format(nodes[0].id))
def test_failure_should_fail(self, workflow_dag_failure):
(g, nodes) = workflow_dag_failure
assert g.has_workflow_failed() is True
assert g.has_workflow_failed() == (True, "Workflow job node {} has a status of 'failed' without an error handler path".format(nodes[0].id))
class TestBFSNodesToRun():