External-Mirrors/awx
2
0
Fork 0
mirror of https://github.com/ansible/awx.git synced 2026-05-15 21:37:42 -02:30
Code Issues Packages Projects Releases Wiki Activity

allow WFJT admins to cancel scheduled jobs

Browse Source
This commit is contained in:
AlanCoding
2017-10-02 10:25:49 -04:00
parent ca4a1f37cd
commit 681770e25a
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
awx/main/access.py
View File

@@ -1841,7 +1841,9 @@ class WorkflowJobAccess(BaseAccess):
def can_cancel(self, obj): def can_cancel(self, obj):
if not obj.can_cancel: if not obj.can_cancel:
return False return False
return self.can_delete(obj) or self.user == obj.created_by if self.user == obj.created_by or self.can_delete(obj):
return True
return obj.workflow_job_template is not None and self.user in obj.workflow_job_template.admin_role
class AdHocCommandAccess(BaseAccess): class AdHocCommandAccess(BaseAccess):

5
awx/main/tests/functional/test_rbac_workflow.py
View File

@@ -104,6 +104,11 @@ class TestWorkflowJobAccess:
access = WorkflowJobAccess(rando) access = WorkflowJobAccess(rando)
assert access.can_cancel(workflow_job) assert access.can_cancel(workflow_job)
def test_admin_cancel_access(self, wfjt, workflow_job, rando):
wfjt.admin_role.members.add(rando)
access = WorkflowJobAccess(rando)
assert access.can_cancel(workflow_job)
@pytest.mark.django_db @pytest.mark.django_db
class TestWFJTCopyAccess: class TestWFJTCopyAccess: