From ddc8871e12fd1bf17e10c7dd3f2a62febf38a4a3 Mon Sep 17 00:00:00 2001 From: AlanCoding Date: Fri, 13 Apr 2018 13:21:38 -0400 Subject: [PATCH] fix test so that playbook runs to completion --- awx/lib/tests/test_display_callback.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/awx/lib/tests/test_display_callback.py b/awx/lib/tests/test_display_callback.py index 1b6b13a67a..68b5702e12 100644 --- a/awx/lib/tests/test_display_callback.py +++ b/awx/lib/tests/test_display_callback.py @@ -195,8 +195,8 @@ def test_callback_plugin_no_log_filters(executor, cache, playbook): - shell: echo "PUBLIC" - shell: echo "PRIVATE" no_log: true - - uri: uri=https://example.org username="PUBLIC" password="PRIVATE" - - copy: content="PRIVATE" destination="/tmp/tmp_no_log" + - uri: url=https://example.org username="PUBLIC" password="PRIVATE" + - copy: content="PRIVATE" dest="/tmp/tmp_no_log" '''}, # noqa ]) def test_callback_plugin_task_args_leak(executor, cache, playbook): @@ -214,6 +214,8 @@ def test_callback_plugin_task_args_leak(executor, cache, playbook): assert events[5]['event'] == 'runner_on_ok' assert 'PUBLIC' in json.dumps(cache.items()) assert 'PRIVATE' not in json.dumps(cache.items()) + # make sure playbook was successful, so all tasks were hit + assert not events[-1]['event_data']['failures'], 'Unexpected playbook execution failure' @pytest.mark.parametrize('playbook', [