add additional merge params test, remove unnecessary span container from search chips

This commit is contained in:
John Mitchell
2020-04-29 16:30:29 -04:00
parent fd91c8e329
commit 697b0c634d
2 changed files with 24 additions and 2 deletions

View File

@@ -187,13 +187,13 @@ class Search extends React.Component {
queryParams[key].forEach(val => queryParams[key].forEach(val =>
queryParamsByKey[columnKey].chips.push({ queryParamsByKey[columnKey].chips.push({
key: `${key}:${val}`, key: `${key}:${val}`,
node: <span>{getLabelFromValue(val, columnKey)}</span>, node: getLabelFromValue(val, columnKey),
}) })
); );
} else { } else {
queryParamsByKey[columnKey].chips.push({ queryParamsByKey[columnKey].chips.push({
key: `${key}:${queryParams[key]}`, key: `${key}:${queryParams[key]}`,
node: <span>{getLabelFromValue(queryParams[key], columnKey)}</span>, node: getLabelFromValue(queryParams[key], columnKey),
}); });
} }
}); });

View File

@@ -652,6 +652,28 @@ describe('qs (qs.js)', () => {
}); });
}); });
it('should not remove empty string values', () => {
const oldParams = {
foo: '',
};
const newParams = {
foo: 'two',
};
expect(mergeParams(oldParams, newParams)).toEqual({
foo: ['', 'two'],
});
const oldParams2 = {
foo: 'one',
};
const newParams2 = {
foo: '',
};
expect(mergeParams(oldParams2, newParams2)).toEqual({
foo: ['one', ''],
});
});
it('should retain unaltered params', () => { it('should retain unaltered params', () => {
const oldParams = { const oldParams = {
foo: 'one', foo: 'one',