From 6d792a823468debe7600f256d6eaa1e93dc2ac91 Mon Sep 17 00:00:00 2001
From: Marliana Lara <mlara@redhat.com>
Date: Wed, 5 Feb 2020 12:04:16 -0500
Subject: [PATCH] Style job output navigation control bar

---
 .../src/screens/Job/JobOutput/JobOutput.jsx   | 30 ++++++++-----------
 .../screens/Job/JobOutput/JobOutput.test.jsx  |  8 ++---
 .../{MenuControls.jsx => PageControls.jsx}    | 19 ++++++------
 ...ontrols.test.jsx => PageControls.test.jsx} |  8 ++---
 4 files changed, 29 insertions(+), 36 deletions(-)
 rename awx/ui_next/src/screens/Job/JobOutput/{MenuControls.jsx => PageControls.jsx} (81%)
 rename awx/ui_next/src/screens/Job/JobOutput/{MenuControls.test.jsx => PageControls.test.jsx} (84%)

diff --git a/awx/ui_next/src/screens/Job/JobOutput/JobOutput.jsx b/awx/ui_next/src/screens/Job/JobOutput/JobOutput.jsx
index e2b38aa694..15775c56ec 100644
--- a/awx/ui_next/src/screens/Job/JobOutput/JobOutput.jsx
+++ b/awx/ui_next/src/screens/Job/JobOutput/JobOutput.jsx
@@ -15,25 +15,21 @@ import ContentError from '@components/ContentError';
 import ContentLoading from '@components/ContentLoading';
 import JobEvent from './JobEvent';
 import JobEventSkeleton from './JobEventSkeleton';
-import MenuControls from './MenuControls';
+import PageControls from './PageControls';
 import HostEventModal from './HostEventModal';
 
 const OutputHeader = styled.div`
   font-weight: var(--pf-global--FontWeight--bold);
 `;
-const OutputToolbar = styled.div`
-  display: flex;
-  justify-content: flex-end;
-`;
+
 const OutputWrapper = styled.div`
-  height: calc(100vh - 350px);
   background-color: #fafafa;
-  margin-top: 24px;
-  font-family: monospace;
-  font-size: 15px;
-  outline: 1px solid #d7d7d7;
   display: flex;
   flex-direction: column;
+  font-family: monospace;
+  font-size: 15px;
+  height: calc(100vh - 350px);
+  outline: 1px solid #d7d7d7;
 `;
 const OutputFooter = styled.div`
   background-color: #ebebeb;
@@ -310,14 +306,12 @@ class JobOutput extends Component {
           />
         )}
         <OutputHeader>{job.name}</OutputHeader>
-        <OutputToolbar>
-          <MenuControls
-            onScrollFirst={this.handleScrollFirst}
-            onScrollLast={this.handleScrollLast}
-            onScrollNext={this.handleScrollNext}
-            onScrollPrevious={this.handleScrollPrevious}
-          />
-        </OutputToolbar>
+        <PageControls
+          onScrollFirst={this.handleScrollFirst}
+          onScrollLast={this.handleScrollLast}
+          onScrollNext={this.handleScrollNext}
+          onScrollPrevious={this.handleScrollPrevious}
+        />
         <OutputWrapper>
           <InfiniteLoader
             isRowLoaded={this.isRowLoaded}
diff --git a/awx/ui_next/src/screens/Job/JobOutput/JobOutput.test.jsx b/awx/ui_next/src/screens/Job/JobOutput/JobOutput.test.jsx
index 987a1ab88f..50c0b71917 100644
--- a/awx/ui_next/src/screens/Job/JobOutput/JobOutput.test.jsx
+++ b/awx/ui_next/src/screens/Job/JobOutput/JobOutput.test.jsx
@@ -21,14 +21,14 @@ async function checkOutput(wrapper, expectedLines) {
 }
 
 async function findScrollButtons(wrapper) {
-  const menuControls = await waitForElement(wrapper, 'MenuControls');
-  const scrollFirstButton = menuControls.find(
+  const pageControls = await waitForElement(wrapper, 'PageControls');
+  const scrollFirstButton = pageControls.find(
     'button[aria-label="scroll first"]'
   );
-  const scrollLastButton = menuControls.find(
+  const scrollLastButton = pageControls.find(
     'button[aria-label="scroll last"]'
   );
-  const scrollPreviousButton = menuControls.find(
+  const scrollPreviousButton = pageControls.find(
     'button[aria-label="scroll previous"]'
   );
   return {
diff --git a/awx/ui_next/src/screens/Job/JobOutput/MenuControls.jsx b/awx/ui_next/src/screens/Job/JobOutput/PageControls.jsx
similarity index 81%
rename from awx/ui_next/src/screens/Job/JobOutput/MenuControls.jsx
rename to awx/ui_next/src/screens/Job/JobOutput/PageControls.jsx
index fbfb5def55..aec23d55e7 100644
--- a/awx/ui_next/src/screens/Job/JobOutput/MenuControls.jsx
+++ b/awx/ui_next/src/screens/Job/JobOutput/PageControls.jsx
@@ -10,26 +10,25 @@ import {
 import styled from 'styled-components';
 
 const Wrapper = styled.div`
-  display: grid;
-  grid-gap: 20px;
-  grid-template-columns: repeat(5, 1fr);
+  display: flex;
+  height: 35px;
+  outline: 1px solid #d7d7d7;
+  width: 100%;
 `;
 
 const Button = styled(PFButton)`
-  &:hover {
-    background-color: #0066cc;
-    color: white;
-  }
+  position: relative;
+  z-index: 1;
 `;
 
-const MenuControls = ({
+const PageControls = ({
   onScrollFirst,
   onScrollLast,
   onScrollNext,
   onScrollPrevious,
 }) => (
   <Wrapper>
-    <Button variant="plain">
+    <Button variant="plain" css="margin-right: auto">
       <PlusIcon />
     </Button>
     <Button
@@ -51,4 +50,4 @@ const MenuControls = ({
   </Wrapper>
 );
 
-export default MenuControls;
+export default PageControls;
diff --git a/awx/ui_next/src/screens/Job/JobOutput/MenuControls.test.jsx b/awx/ui_next/src/screens/Job/JobOutput/PageControls.test.jsx
similarity index 84%
rename from awx/ui_next/src/screens/Job/JobOutput/MenuControls.test.jsx
rename to awx/ui_next/src/screens/Job/JobOutput/PageControls.test.jsx
index 8ac5fe4c46..210c33feb9 100644
--- a/awx/ui_next/src/screens/Job/JobOutput/MenuControls.test.jsx
+++ b/awx/ui_next/src/screens/Job/JobOutput/PageControls.test.jsx
@@ -1,6 +1,6 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import MenuControls from './MenuControls';
+import PageControls from './PageControls';
 
 let wrapper;
 let PlusIcon;
@@ -17,14 +17,14 @@ const findChildren = () => {
   AngleDownIcon = wrapper.find('AngleDownIcon');
 };
 
-describe('MenuControls', () => {
+describe('PageControls', () => {
   test('should render successfully', () => {
-    wrapper = mount(<MenuControls />);
+    wrapper = mount(<PageControls />);
     expect(wrapper).toHaveLength(1);
   });
 
   test('should render menu control icons', () => {
-    wrapper = mount(<MenuControls />);
+    wrapper = mount(<PageControls />);
     findChildren();
     expect(PlusIcon.length).toBe(1);
     expect(AngleDoubleUpIcon.length).toBe(1);