SCM Inventory model, view, and task system changes

Inventory source file-type combined with a linked project
will allow the inventory source to be updated when the
project is updated. The inventory update runs in the
post-run hook of the project update.

awx/main/tests/functional/conftest.py

@@ -133,7 +133,9 @@ def project(instance, organization):
     prj = Project.objects.create(name="test-proj",
                                  description="test-proj-desc",
                                  organization=organization,
-                                 playbook_files=['helloworld.yml', 'alt-helloworld.yml']
+                                 playbook_files=['helloworld.yml', 'alt-helloworld.yml'],
+                                 local_path='_92__test_proj',
+                                 scm_revision='1234567890123456789012345678901234567890'
                                  )
     return prj
 
@@ -208,6 +210,15 @@ def inventory(organization):
     return organization.inventories.create(name="test-inv")
 
 
+@pytest.fixture
+def scm_inventory_source(inventory, project):
+    return InventorySource.objects.create(
+        name="test-scm-inv",
+        scm_project=project,
+        source_path='inventory_file',
+        inventory=inventory)
+
+
 @pytest.fixture
 def inventory_factory(organization):
     def factory(name, org=organization):

awx/main/tests/functional/models/test_inventory.py

@@ -0,0 +1,33 @@
+import pytest
+import mock
+
+# AWX
+from awx.main.models import InventorySource, InventoryUpdate
+
+
+@pytest.mark.django_db
+class TestSCMUpdateFeatures:
+
+    def test_automatic_project_update_on_create(self, inventory, project):
+        inv_src = InventorySource(
+            scm_project=project,
+            source_path='inventory_file',
+            inventory=inventory)
+        with mock.patch.object(inv_src.scm_project, 'update') as mck_update:
+            inv_src.save()
+            mck_update.assert_called_once_with()
+
+    def test_source_location(self, scm_inventory_source):
+        # Combines project directory with the inventory file specified
+        inventory_update = InventoryUpdate(
+            inventory_source=scm_inventory_source,
+            source_path=scm_inventory_source.source_path)
+        assert inventory_update.get_actual_source_path().endswith('_92__test_proj/inventory_file')
+
+    def test_no_unwanted_updates(self, scm_inventory_source):
+        # Changing the non-sensitive fields should not trigger update
+        with mock.patch.object(scm_inventory_source.scm_project, 'update') as mck_update:
+            scm_inventory_source.name = 'edited_inventory'
+            scm_inventory_source.description = "I'm testing this!"
+            scm_inventory_source.save()
+            assert not mck_update.called

awx/main/tests/functional/test_projects.py

@@ -24,6 +24,13 @@ def team_project_list(organization_factory):
     return objects
 
 
+@pytest.mark.django_db
+def test_get_project_path(project):
+    # Test combining projects root with project local path
+    with mock.patch('awx.main.models.projects.settings.PROJECTS_ROOT', '/var/lib/awx'):
+        assert project.get_project_path(check_if_exists=False) == '/var/lib/awx/_92__test_proj'
+
+
 @pytest.mark.django_db
 def test_user_project_paged_list(get, organization_factory):
     'Test project listing that spans multiple pages'

awx/main/tests/functional/test_tasks.py

@@ -0,0 +1,43 @@
+import pytest
+import mock
+import os
+
+from awx.main.tasks import RunProjectUpdate, RunInventoryUpdate
+from awx.main.models import ProjectUpdate, InventoryUpdate
+
+
+@pytest.fixture
+def scm_revision_file(tmpdir_factory):
+    # Returns path to temporary testing revision file
+    revision_file = tmpdir_factory.mktemp('revisions').join('revision.txt')
+    with open(str(revision_file), 'w') as f:
+        f.write('1234567890123456789012345678901234567890')
+    return os.path.join(revision_file.dirname, 'revision.txt')
+
+
+@pytest.mark.django_db
+class TestDependentInventoryUpdate:
+
+    def test_dependent_inventory_updates_is_called(self, scm_inventory_source, scm_revision_file):
+        task = RunProjectUpdate()
+        task.revision_path = scm_revision_file
+        proj_update = ProjectUpdate.objects.create(project=scm_inventory_source.scm_project)
+        with mock.patch.object(RunProjectUpdate, '_update_dependent_inventories') as inv_update_mck:
+            task.post_run_hook(proj_update, 'successful')
+            inv_update_mck.assert_called_once_with(scm_inventory_source.scm_project, mock.ANY)
+
+    def test_no_unwanted_dependent_inventory_updates(self, project, scm_revision_file):
+        task = RunProjectUpdate()
+        task.revision_path = scm_revision_file
+        proj_update = ProjectUpdate.objects.create(project=project)
+        with mock.patch.object(RunProjectUpdate, '_update_dependent_inventories') as inv_update_mck:
+            task.post_run_hook(proj_update, 'successful')
+            assert not inv_update_mck.called
+
+    def test_dependent_inventory_updates(self, scm_inventory_source):
+        task = RunProjectUpdate()
+        with mock.patch.object(RunInventoryUpdate, 'run') as iu_run_mock:
+            task._update_dependent_inventories(scm_inventory_source.scm_project, [scm_inventory_source])
+            assert InventoryUpdate.objects.count() == 1
+            inv_update = InventoryUpdate.objects.first()
+            iu_run_mock.assert_called_once_with(inv_update.id)