From bdad9ac8f92d3d90287c6605ffed5baf88ff1adc Mon Sep 17 00:00:00 2001
From: Jake McDermott <yo@jakemcdermott.me>
Date: Mon, 29 Apr 2019 10:05:14 -0400
Subject: [PATCH] use 'handle' notation for header toolbar methods

- 'handleFoo' is for methods defined on the component
- 'onFoo' is for naming function props that can be passed to the component from its parents
---
 src/components/PageHeaderToolbar.jsx | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/components/PageHeaderToolbar.jsx b/src/components/PageHeaderToolbar.jsx
index 01277b1f4b..8278cfa908 100644
--- a/src/components/PageHeaderToolbar.jsx
+++ b/src/components/PageHeaderToolbar.jsx
@@ -28,29 +28,29 @@ class PageHeaderToolbar extends Component {
       isUserOpen: false,
     };
 
-    this.onHelpSelect = this.onHelpSelect.bind(this);
-    this.onHelpToggle = this.onHelpToggle.bind(this);
-    this.onUserSelect = this.onUserSelect.bind(this);
-    this.onUserToggle = this.onUserToggle.bind(this);
+    this.handleHelpSelect = this.handleHelpSelect.bind(this);
+    this.handleHelpToggle = this.handleHelpToggle.bind(this);
+    this.handleUserSelect = this.handleUserSelect.bind(this);
+    this.handleUserToggle = this.handleUserToggle.bind(this);
   }
 
-  onHelpSelect () {
+  handleHelpSelect () {
     const { isHelpOpen } = this.state;
 
     this.setState({ isHelpOpen: !isHelpOpen });
   }
 
-  onUserSelect () {
+  handleUserSelect () {
     const { isUserOpen } = this.state;
 
     this.setState({ isUserOpen: !isUserOpen });
   }
 
-  onHelpToggle (isOpen) {
+  handleHelpToggle (isOpen) {
     this.setState({ isHelpOpen: isOpen });
   }
 
-  onUserToggle (isOpen) {
+  handleUserToggle (isOpen) {
     this.setState({ isUserOpen: isOpen });
   }
 
@@ -74,10 +74,10 @@ class PageHeaderToolbar extends Component {
                     isPlain
                     isOpen={isHelpOpen}
                     position={DropdownPosition.right}
-                    onSelect={this.onHelpSelect}
+                    onSelect={this.handleHelpSelect}
                     toggle={(
                       <DropdownToggle
-                        onToggle={this.onHelpToggle}
+                        onToggle={this.handleHelpToggle}
                       >
                         <QuestionCircleIcon />
                       </DropdownToggle>
@@ -113,10 +113,10 @@ class PageHeaderToolbar extends Component {
                     isPlain
                     isOpen={isUserOpen}
                     position={DropdownPosition.right}
-                    onSelect={this.onUserSelect}
+                    onSelect={this.handleUserSelect}
                     toggle={(
                       <DropdownToggle
-                        onToggle={this.onUserToggle}
+                        onToggle={this.handleUserToggle}
                       >
                         <UserIcon />
                         &nbsp; User Name