From 722ae932ab595e7641b14fb72b0086eae5ece50e Mon Sep 17 00:00:00 2001
From: John Mitchell <jlmitch5@ncsu.edu>
Date: Mon, 8 Apr 2019 12:20:44 -0400
Subject: [PATCH] update login modal to grab error from RootDialog

---
 src/app.scss        |  8 ++++++++
 src/pages/Login.jsx | 31 +++++++++++++++++--------------
 2 files changed, 25 insertions(+), 14 deletions(-)

diff --git a/src/app.scss b/src/app.scss
index 08b66f24c0..20df8aa24b 100644
--- a/src/app.scss
+++ b/src/app.scss
@@ -356,3 +356,11 @@
     color: var(--pf-global--success-color--200);
   }
 }
+
+//
+// LoginModal overrides
+//
+
+.pf-m-error p.pf-c-form__helper-text {
+  color: var(--pf-global--danger-color--100);
+}
diff --git a/src/pages/Login.jsx b/src/pages/Login.jsx
index 4759f285c7..2a216ed505 100644
--- a/src/pages/Login.jsx
+++ b/src/pages/Login.jsx
@@ -1,5 +1,5 @@
 import React, { Component } from 'react';
-import { Redirect } from 'react-router-dom';
+import { Redirect, withRouter } from 'react-router-dom';
 import { I18n } from '@lingui/react';
 import { t } from '@lingui/macro';
 import {
@@ -7,6 +7,9 @@ import {
   LoginPage,
 } from '@patternfly/react-core';
 
+import { withRootDialog } from '../contexts/RootDialog';
+import { withNetwork } from '../contexts/Network';
+
 import towerLogo from '../../images/tower-logo-header.svg';
 
 class AWXLogin extends Component {
@@ -17,7 +20,8 @@ class AWXLogin extends Component {
       username: '',
       password: '',
       isInputValid: true,
-      isLoading: false
+      isLoading: false,
+      isAuthenticated: false
     };
 
     this.onChangeUsername = this.onChangeUsername.bind(this);
@@ -35,7 +39,7 @@ class AWXLogin extends Component {
 
   async onLoginButtonClick (event) {
     const { username, password, isLoading } = this.state;
-    const { api } = this.props;
+    const { api, handleHttpError, clearRootDialogMessage } = this.props;
 
     event.preventDefault();
 
@@ -43,25 +47,23 @@ class AWXLogin extends Component {
       return;
     }
 
+    clearRootDialogMessage();
     this.setState({ isLoading: true });
 
     try {
       await api.login(username, password);
+      this.setState({ isAuthenticated: true, isLoading: false });
     } catch (error) {
-      if (error.response && error.response.status === 401) {
-        this.setState({ isInputValid: false });
-      }
-    } finally {
-      this.setState({ isLoading: false });
+      handleHttpError(error) || this.setState({ isInputValid: false, isLoading: false });
     }
   }
 
   render () {
-    const { username, password, isInputValid } = this.state;
-    const { api, alt, loginInfo, logo } = this.props;
+    const { username, password, isInputValid, isAuthenticated } = this.state;
+    const { alt, loginInfo, logo, bodyText: errorMessage } = this.props;
     const logoSrc = logo ? `data:image/jpeg;${logo}` : towerLogo;
 
-    if (api.isAuthenticated()) {
+    if (isAuthenticated) {
       return (<Redirect to="/" />);
     }
 
@@ -75,10 +77,11 @@ class AWXLogin extends Component {
             textContent={loginInfo}
           >
             <LoginForm
+              className={errorMessage && 'pf-m-error'}
               usernameLabel={i18n._(t`Username`)}
               passwordLabel={i18n._(t`Password`)}
-              showHelperText={!isInputValid}
-              helperText={i18n._(t`Invalid username or password. Please try again.`)}
+              showHelperText={!isInputValid || !!errorMessage}
+              helperText={errorMessage || i18n._(t`Invalid username or password. Please try again.`)}
               usernameValue={username}
               passwordValue={password}
               isValidUsername={isInputValid}
@@ -94,4 +97,4 @@ class AWXLogin extends Component {
   }
 }
 
-export default AWXLogin;
+export default withNetwork(withRootDialog(withRouter(AWXLogin)));