fix jshint errors

This commit is contained in:
mabashian
2019-08-13 15:36:15 -04:00
committed by Ryan Petrello
parent bdf4defdbe
commit 73485b220e
4 changed files with 8 additions and 8 deletions

View File

@@ -94,7 +94,7 @@ export default function BuildAnchor($log, $filter) {
url += `applications/${obj.id}`; url += `applications/${obj.id}`;
break; break;
case 'workflow_approval': case 'workflow_approval':
url += `workflows/${activity.summary_fields.workflow_job[0].id}` url += `workflows/${activity.summary_fields.workflow_job[0].id}`;
name = activity.summary_fields.workflow_job[0].name; name = activity.summary_fields.workflow_job[0].name;
break; break;
default: default:

View File

@@ -124,9 +124,9 @@ export default function BuildDescription(BuildAnchor, $log, i18n) {
break; break;
// expected outcome: "operation <object1>" // expected outcome: "operation <object1>"
case 'update': case 'update':
if (activity.object1 === 'workflow_approval' if (activity.object1 === 'workflow_approval' &&
&& _.has(activity, 'changes.status') _.has(activity, 'changes.status') &&
&& activity.changes.status.length === 2 activity.changes.status.length === 2
) { ) {
let operationText = ''; let operationText = '';
if (activity.changes.status[1] === 'successful') { if (activity.changes.status[1] === 'successful') {

View File

@@ -115,7 +115,7 @@ export default ['$scope','Wait', '$timeout', 'i18n',
$scope.graphData.jobStatus = value.data; $scope.graphData.jobStatus = value.data;
}) })
.catch(function({data, status}) { .catch(function({data, status}) {
processErrors(null, data, status, null, { hdr: i18n._('Error!'), msg: i18n._(`Failed to get dashboard graph data: ${response.status}`)}); ProcessErrors(null, data, status, null, { hdr: i18n._('Error!'), msg: i18n._(`Failed to get dashboard graph data: ${status}`)});
}); });
} }

View File

@@ -97,9 +97,9 @@ export default
var data = JSON.parse(e.data), str = ""; var data = JSON.parse(e.data), str = "";
if (data.group_name === 'jobs' if (data.group_name === 'jobs' &&
&& 'type' in data 'type' in data &&
&& data.type === 'workflow_approval' data.type === 'workflow_approval'
) { ) {
$rootScope.$broadcast('ws-approval'); $rootScope.$broadcast('ws-approval');
} }