From 7590301ae74db5d37f1afc40ebe89f366af61a76 Mon Sep 17 00:00:00 2001 From: Lila Date: Mon, 7 Nov 2022 14:44:42 -0500 Subject: [PATCH] Fix for incorrect error messages on incomplete credentials. --- awx/main/models/unified_jobs.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/awx/main/models/unified_jobs.py b/awx/main/models/unified_jobs.py index bd254fc182..40132dc2ab 100644 --- a/awx/main/models/unified_jobs.py +++ b/awx/main/models/unified_jobs.py @@ -1345,15 +1345,17 @@ class UnifiedJob( # verify that any associated credentials aren't missing required field data missing_credential_inputs = [] + credential_name = "" for credential in self.credentials.all(): defined_fields = credential.credential_type.defined_fields for required in credential.credential_type.inputs.get('required', []): if required in defined_fields and not credential.has_input(required): missing_credential_inputs.append(required) + credential_name = credential.name if missing_credential_inputs: self.job_explanation = '{} cannot start because Credential {} does not provide one or more required fields ({}).'.format( - self._meta.verbose_name.title(), credential.name, ', '.join(sorted(missing_credential_inputs)) + self._meta.verbose_name.title(), credential_name, ', '.join(sorted(missing_credential_inputs)) ) self.save(update_fields=['job_explanation']) return (False, None)